From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFCv3 07/14] drm: Specify primary plane at CRTC initialization (v2) Date: Thu, 20 Mar 2014 16:38:00 +0100 Message-ID: <20140320153800.GS30571@phenom.ffwll.local> References: <1395188579-17191-1-git-send-email-matthew.d.roper@intel.com> <1395188579-17191-8-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C3116E0EE for ; Thu, 20 Mar 2014 08:38:05 -0700 (PDT) Received: by mail-ee0-f54.google.com with SMTP id d49so814355eek.13 for ; Thu, 20 Mar 2014 08:38:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae Cc: DRI mailing list List-Id: dri-devel@lists.freedesktop.org On Thu, Mar 20, 2014 at 02:43:11PM +0900, Inki Dae wrote: > Your patch would make kms requests to be broken. Exynos drm uses a > wrapper structure, exynos_plane, including original drm_plane, and > also a overlay object specific to exynos should be sent to crtc driver > through exynos_plane. > > And re-factoring patch series for exynos drm framework will go to > -next soon. So how about that other maintainers can adopt your primary > plane feature individually later? For this, I guess you would need to > keep backward compatibility. We would really need the testing enough > for such feature and big changes. All my review thus far has been aimed at reducing subsystem-wide changes to drivers. I think we can do the full primary plane conversion without touching drivers at all. Of course there's a bit of cleanup, but driver maintainers can merge that at their own pace (and so avoid ugly conflicts with ongoing work). I'm still working on how to reduce the impact for the cursor plane conversion as much as possible, but that's going to be fairly hard unfortunately. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch