From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/dp: make aux retries less chatty Date: Fri, 21 Mar 2014 19:01:32 +0100 Message-ID: <20140321180116.GA26519@phenom.ffwll.local> References: <1395412448-28048-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id DAC416E3E0 for ; Fri, 21 Mar 2014 11:01:51 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id c13so2088486eek.24 for ; Fri, 21 Mar 2014 11:01:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395412448-28048-1-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Alex Deucher , christian.koenig@amd.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Mar 21, 2014 at 10:34:06AM -0400, Alex Deucher wrote: > Switch to debug only to avoid flooding the logs. > This mirrors the behavior in some other drivers. > > Signed-off-by: Alex Deucher > Reviewed-by: Daniel Vetter Btw I've just noticed that we have a 2nd retry loop with 3 retries and a 1 msec delay which apparently is needed to kick suspended dp sinks out of their sleep. See intel_dp_dpcd_read_wake in intel_dp.c. Should we maybe move that 2nd loop into these helpers, too? -Daniel > --- > drivers/gpu/drm/drm_dp_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 35251af..74724aa 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -402,7 +402,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, > } > } > > - DRM_ERROR("too many retries, giving up\n"); > + DRM_DEBUG_KMS("too many retries, giving up\n"); > return -EIO; > } > > @@ -656,7 +656,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) > } > } > > - DRM_ERROR("too many retries, giving up\n"); > + DRM_DEBUG_KMS("too many retries, giving up\n"); > return -EREMOTEIO; > } > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch