From: Ben Widawsky <ben@bwidawsk.net>
To: Dave Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 20/34] drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c
Date: Fri, 21 Mar 2014 23:45:12 -0700 [thread overview]
Message-ID: <20140322064511.GA7115@bwidawsk.net> (raw)
In-Reply-To: <CAPM=9tzOD2LqxFra6SdqQVGArCXL1x9fBok2SPxdOqCYM9ehzg@mail.gmail.com>
On Thu, Mar 20, 2014 at 11:31:26AM +1000, Dave Airlie wrote:
> On Tue, Mar 11, 2014 at 8:30 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > There's not really any value in stating that no locking is needed. And
> > even if the comment is useful, a check for the right mutex at the
> > beginning of the function is better since that can't be ingored as
> > easily as a bit of documentation.
> >
> > Note that drm_mode_probed_add in drm_crtc.c is also changed, the next
> > patch will move this into drm_modes.c
> >
> > v2: Don't add locking WARN_ONs where it is not strictly required (i.e.
> > the two functions to validate/prune mode lists).
>
> This made radeon blow up hard, I kinda expect other drivers also,
>
>
> >Mar 20 01:14:21 crydee kernel: ------------[ cut here ]------------
> Mar 20 01:14:21 crydee kernel: WARNING: CPU: 3 PID: 882 at
> /home/airlied/kernel/linux-2.6/drivers/gpu/drm/drm_crtc.c:94
> drm_warn_on_modeset_not_all_locked+0x48/0x76 [drm]()
> Mar 20 01:14:21 crydee kernel: Modules linked in: firewire_ohci
> firewire_core crc_itu_t ehci_pci ohci_pci ehci_hcd ohci_hcd radeon(+)
> hwmon i2c_algo_bit drm_kms_helper ttm drm i2c_core
> Mar 20 01:14:21 crydee kernel: CPU: 3 PID: 882 Comm: systemd-udevd Not
> tainted 3.14.0-rc7+ #67
> Mar 20 01:14:21 crydee kernel: Hardware name: Gigabyte Technology Co.,
> Ltd. GA-A75M-UD2H/GA-A75M-UD2H, BIOS F4 09/16/2011
> Mar 20 01:14:21 crydee kernel: 0000000000000000 ffff88022311f9c8
> ffffffff814b5b21 0000000000000000
> Mar 20 01:14:21 crydee kernel: ffff88022311fa00 ffffffff81039e11
> ffffffffa001882f ffff880036b92000
> Mar 20 01:14:21 crydee kernel: ffff880224c85000 ffff880224c85690
> 0000000000000000 ffff88022311fa10
> Mar 20 01:14:21 crydee kernel: Call Trace:
> Mar 20 01:14:21 crydee kernel: [<ffffffff814b5b21>] dump_stack+0x4d/0x66
> Mar 20 01:14:21 crydee kernel: [<ffffffff81039e11>]
> warn_slowpath_common+0x7a/0x93
> Mar 20 01:14:21 crydee kernel: [<ffffffffa001882f>] ?
> drm_warn_on_modeset_not_all_locked+0x48/0x76 [drm]
> Mar 20 01:14:21 crydee kernel: [<ffffffff81039ec9>]
> warn_slowpath_null+0x15/0x17
> Mar 20 01:14:21 crydee kernel: [<ffffffffa001882f>]
> drm_warn_on_modeset_not_all_locked+0x48/0x76 [drm]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa00853b4>]
> drm_helper_disable_unused_functions+0x11/0x103 [drm_kms_helper]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa00c39ed>]
> radeon_fbdev_init+0xb2/0xcf [radeon]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa00bf623>]
> radeon_modeset_init+0x763/0x951 [radeon]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa00a21f3>]
> radeon_driver_load_kms+0xc5/0x171 [radeon]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa0013c53>]
> drm_dev_register+0x7f/0xf8 [drm]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa0015e12>]
> drm_get_pci_dev+0xfe/0x1c8 [drm]
> Mar 20 01:14:21 crydee kernel: [<ffffffff81078ac0>] ? trace_hardirqs_on+0xd/0xf
> Mar 20 01:14:21 crydee kernel: [<ffffffffa009f341>]
> radeon_pci_probe+0xa8/0xaf [radeon]
> Mar 20 01:14:21 crydee kernel: [<ffffffff81285376>] local_pci_probe+0x38/0x7d
> Mar 20 01:14:21 crydee kernel: [<ffffffff81285481>] pci_device_probe+0xc6/0xec
> Mar 20 01:14:21 crydee kernel: [<ffffffff813149a5>]
> driver_probe_device+0x98/0x1b3
> Mar 20 01:14:21 crydee kernel: [<ffffffff81314b54>] __driver_attach+0x5c/0x7e
> Mar 20 01:14:21 crydee kernel: [<ffffffff81314af8>] ? __device_attach+0x38/0x38
> Mar 20 01:14:21 crydee kernel: [<ffffffff813130ae>] bus_for_each_dev+0x79/0x83
> Mar 20 01:14:21 crydee kernel: [<ffffffff8131452c>] driver_attach+0x19/0x1b
> Mar 20 01:14:21 crydee kernel: [<ffffffff813141ee>] bus_add_driver+0x109/0x1d3
> Mar 20 01:14:21 crydee kernel: [<ffffffff81315095>] driver_register+0x89/0xc5
> Mar 20 01:14:21 crydee kernel: [<ffffffff81284acd>]
> __pci_register_driver+0x5b/0x5e
> Mar 20 01:14:21 crydee kernel: [<ffffffffa01c1000>] ? 0xffffffffa01c0fff
> Mar 20 01:14:21 crydee kernel: [<ffffffffa0015f45>]
> drm_pci_init+0x69/0xec [drm]
> Mar 20 01:14:21 crydee kernel: [<ffffffffa01c1000>] ? 0xffffffffa01c0fff
> Mar 20 01:14:21 crydee kernel: [<ffffffffa01c1097>]
> radeon_init+0x97/0xb5 [radeon]
>
> Dave.
i915 gets 3 distinct WARNs from this patch.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-22 6:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:29 [PATCH 00/34] drm: moar kerneldoc and cleanups Daniel Vetter
2014-03-11 10:29 ` [PATCH 01/34] drm/doc: Clarify the dumb object interfaces Daniel Vetter
2014-03-11 10:29 ` [PATCH 02/34] drm/doc: Fix up kerneldoc in drm_edid.c Daniel Vetter
2014-03-11 10:29 ` [PATCH 03/34] drm/doc: Clean up and integrate kerneldoc for drm_gem.c Daniel Vetter
2014-03-11 10:30 ` [PATCH 04/34] drm/doc: Remove <term> from rendernode docs Daniel Vetter
2014-03-11 10:30 ` [PATCH 05/34] drm/doc: Reorganize driver documentation Daniel Vetter
2014-03-11 10:30 ` [PATCH 06/34] drm/doc: Move the vma offset manager to the right spot Daniel Vetter
2014-03-11 10:30 ` [PATCH 07/34] drm/doc: Remove the "command submissin and fencing" section Daniel Vetter
2014-03-11 10:30 ` [PATCH 08/34] drm/doc: No more drm perf counters Daniel Vetter
2014-03-11 10:30 ` [PATCH 09/34] drm/doc: Document drm_helper_resume_force_mode Daniel Vetter
2014-03-11 10:30 ` [PATCH 10/34] drm/doc: Hide legacy horrors better Daniel Vetter
2014-03-11 10:30 ` [PATCH 11/34] drm/docs: Include hdmi infoframe helper reference Daniel Vetter
2014-03-11 10:30 ` [PATCH 12/34] drm/doc: Clarify PRIME documentation Daniel Vetter
2014-03-11 10:30 ` [PATCH 13/34] drm/doc: Add PRIME function references Daniel Vetter
2014-03-11 10:30 ` [PATCH 14/34] drm/doc: Update copyright Daniel Vetter
2014-03-11 10:30 ` [PATCH 15/34] drm/mm: Remove MM_UNUSED_TARGET Daniel Vetter
2014-03-11 10:30 ` [PATCH 16/34] drm/doc: Overview documentation for drm_mm.c Daniel Vetter
2014-03-11 10:30 ` [PATCH 17/34] drm/doc: Add fucntion reference " Daniel Vetter
2014-03-11 10:30 ` [PATCH 18/34] drm/kms: rip out drm_mode_connector_detach_encoder Daniel Vetter
2014-03-11 10:30 ` [PATCH 19/34] drm/doc: Integrate drm_modes.c kerneldoc Daniel Vetter
2014-03-11 10:30 ` [PATCH 20/34] drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c Daniel Vetter
2014-03-20 1:31 ` Dave Airlie
2014-03-22 6:45 ` Ben Widawsky [this message]
2014-03-23 8:19 ` Daniel Vetter
2014-03-11 10:30 ` [PATCH 21/34] drm: move drm_mode related functions into drm_modes.c Daniel Vetter
2014-03-11 10:30 ` [PATCH 22/34] drm: extract drm_modes.h for drm_modes.c functions Daniel Vetter
2014-03-11 10:30 ` [PATCH 23/34] drm/modes: remove drm_mode_height/width Daniel Vetter
2014-03-11 10:30 ` [PATCH 24/34] drm/modes: drop return value from drm_display_mode_from_videomode Daniel Vetter
2014-03-11 10:30 ` [PATCH 25/34] drm/modes: drop maxPitch from drm_mode_validate_size Daniel Vetter
2014-03-11 10:30 ` [PATCH 26/34] drm: polish function kerneldoc for drm_modes.[hc] Daniel Vetter
2014-03-11 10:30 ` [PATCH 27/34] drm: remove drm_display_mode->private_size Daniel Vetter
2014-03-11 10:30 ` [PATCH 28/34] drm/doc: Fix misplaced </para> Daniel Vetter
2014-03-11 10:30 ` [PATCH 29/34] drm: remove return value from drm_helper_mode_fill_fb_struct Daniel Vetter
2014-03-11 10:30 ` [PATCH 30/34] drm/crtc-helper: remove LOCKING from kerneldoc Daniel Vetter
2014-03-11 10:30 ` [PATCH 31/34] drm: drop error code for drm_helper_resume_force_mode Daniel Vetter
2014-03-11 10:30 ` [PATCH 32/34] drm: kerneldoc polish for drm_crtc_helper.c Daniel Vetter
2014-03-11 10:30 ` [PATCH 33/34] drm: kerneldoc polish for drm_crtc.c Daniel Vetter
2014-03-11 10:30 ` [PATCH 34/34] drm/kms: don't export drm_mode_group_init_legacy_group Daniel Vetter
2014-03-11 14:16 ` [PATCH 00/34] drm: moar kerneldoc and cleanups Alex Deucher
2014-03-15 11:15 ` [PATCH] drm/imx: remove drm_mode_connector_detach_encoder harder Daniel Vetter
2014-03-15 11:23 ` Russell King - ARM Linux
2014-03-15 11:35 ` Daniel Vetter
2014-03-17 21:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322064511.GA7115@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=airlied@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox