From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/11] A few patches around DRM logging Date: Mon, 24 Mar 2014 21:41:50 +0100 Message-ID: <20140324204150.GM26878@phenom.ffwll.local> References: <1395676398-7058-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E39D89CD9 for ; Mon, 24 Mar 2014 13:41:55 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id t10so4936791eei.0 for ; Mon, 24 Mar 2014 13:41:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395676398-7058-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Damien Lespiau Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Mar 24, 2014 at 03:53:07PM +0000, Damien Lespiau wrote: > As patch 8/11 explains, I noticed that we where evaluating the arguments to > drm_ut_debug_printk() even when drm.debug was 0, doing some work for no good > reason. By pulling the test on drm_debug before calling drm_ut_debug_printk(), > we skip those instructions that only need to be executed when logging is on. > > The remaining patches are bonus clean-ups, with the main goal of removing > DRM_LOG* macros that are not really used throughout the code base. After that, > it's possible to simplify a bit drm_ut_debug_printk(). All pretty > straightforward cleanups, but still worthwhile IMHO. > > For driver-specific patches (why some of you are Cced in that series), I'd love > if you could take the time to throw a Acked-by/Reviewed-by tag. Also, do you > have any objection if the driver specific patch go through the DRM tree? > should people judge that series worthwhile, of course. Except for the gma500 patch this series is Reviewed-by: Daniel Vetter For the gma500 I've replied with my opinion but will defer to Patrik. -Daniel > > -- > Damien > > Damien Lespiau (11): > drm: Refresh the explanation of debug categories > drm: Remove the unused (and unusable) DRM_LOG_MODE() > drm/exynos: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS() > drm/gma500: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS() > drm/i915: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS() > staging: imx-drm: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS() > drm: Remove the now unused DRM_LOG* macros > drm: Pull the test on drm_debug in the logging macros > drm: drm_ut_debug_printk() isn't called with NULL anywmore > drm: Remove the prefix argument of drm_ut_debug_printk() > drm: Remove the ',' after the function name in debug logs > > drivers/gpu/drm/drm_stub.c | 24 +++---- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +- > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 20 +++--- > drivers/gpu/drm/i915/dvo_ch7xxx.c | 4 +- > drivers/gpu/drm/i915/dvo_ivch.c | 30 ++++----- > drivers/gpu/drm/i915/dvo_ns2501.c | 10 +-- > drivers/gpu/drm/i915/dvo_sil164.c | 10 +-- > drivers/gpu/drm/i915/dvo_tfp410.c | 24 +++---- > drivers/staging/imx-drm/ipuv3-plane.c | 2 +- > include/drm/drmP.h | 106 +++++++++++------------------- > 11 files changed, 98 insertions(+), 136 deletions(-) > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch