From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCHv4 04/13] drm/shmobile: Restrict plane loops to only operate on legacy planes Date: Fri, 28 Mar 2014 18:53:40 +0100 Message-ID: <20140328175340.GJ22327@phenom.ffwll.local> References: <1395967478-30549-1-git-send-email-matthew.d.roper@intel.com> <1395967478-30549-5-git-send-email-matthew.d.roper@intel.com> <18133792.tr0thX4a4c@avalon> <20140328175250.GI22327@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 330516ED78 for ; Fri, 28 Mar 2014 10:53:44 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c41so4297770eek.22 for ; Fri, 28 Mar 2014 10:53:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140328175250.GI22327@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Mar 28, 2014 at 06:52:50PM +0100, Daniel Vetter wrote: > On Fri, Mar 28, 2014 at 04:50:13PM +0100, Laurent Pinchart wrote: > > Hi Matt, > > > > Thank you for the patch. > > > > On Thursday 27 March 2014 17:44:29 Matt Roper wrote: > > > Ensure that existing driver loops over all planes do not change behavior > > > when we begin adding new types of planes (primary and cursor) to the DRM > > > plane list in future patches. > > > > > > Cc: Laurent Pinchart > > > Signed-off-by: Matt Roper > > > > Acked-by: Laurent Pinchart > > > > I have a question though. The patch set introduces three plane types, OVERLAY, > > PRIMARY and CURSOR. What should a driver that has no concept of primary plane > > do ? Expose all planes as OVERLAY planes only ? > > It's a matter of backwards compat with old userspace. primary/cursor are > simply ways to tell the drm core which planes to use to forward the legacy > cursor crtc and which plane will be used for the framebuffer in setCrtc. > > So until we have the new atomic interface ready your driver kinda needs to > expose at least a primary plane, otherwise there's no way to even switch > on the crtc. > > But besides this backwards compat issue there's no difference and you can > specify whatever plane you want as primary/cursor (or none if you don't > care about old userspace). Well the NULL primary plane probably needs a bit of work on top of Matt's patch series here ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch