From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id
Date: Mon, 7 Apr 2014 21:46:54 +0800
Message-ID: <20140407134649.GA3860@dragon>
References: <1396858956-7096-1-git-send-email-p.zabel@pengutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from tx2outboundpool.messaging.microsoft.com
 (tx2ehsobe007.messaging.microsoft.com [65.55.88.31])
 by gabe.freedesktop.org (Postfix) with ESMTP id 616506E65D
 for <dri-devel@lists.freedesktop.org>; Mon,  7 Apr 2014 06:47:03 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1396858956-7096-1-git-send-email-p.zabel@pengutronix.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@pengutronix.de, Russell King <rmk+kernel@arm.linux.org.uk>
List-Id: dri-devel@lists.freedesktop.org

On Mon, Apr 07, 2014 at 10:22:36AM +0200, Philipp Zabel wrote:
> The decoder mux id is equal to the port id of the encoder's input port
> that is connected to the given crtc, not to the endpoint id (which is
> arbitrary and usually zero).
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

It fixes a color corruption issue on my dual display case (LVDS + HDMI).

Tested-by: Shawn Guo <shawn.guo@freescale.com>

Shawn

> ---
>  drivers/staging/imx-drm/imx-drm-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index 4144a75..bc7f8bd 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -517,7 +517,7 @@ int imx_drm_encoder_get_mux_id(struct device_node *node,
>  		of_node_put(port);
>  		if (port == imx_crtc->port) {
>  			ret = of_graph_parse_endpoint(ep, &endpoint);
> -			return ret ? ret : endpoint.id;
> +			return ret ? ret : endpoint.port;
>  		}
>  	} while (ep);
>  
> -- 
> 1.9.1
>