From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lauri Kasanen Subject: Re: [PATCH] drm/radeon: Inline r100_mm_rreg Date: Fri, 11 Apr 2014 19:47:36 +0300 Message-ID: <20140411194736.01195730.cand@gmx.com> References: <20140410160817.5275493d.cand@gmx.com> <20140410214634.ba440af5.cand@gmx.com> <5346F13B.6060604@vodafone.de> <20140411105201.57ea4a1b.cand@gmx.com> <5347A8C4.90307@vodafone.de> <20140411125417.ce34db7e.cand@gmx.com> <5347E0D4.3040205@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by gabe.freedesktop.org (Postfix) with ESMTP id C2FF16E3E8 for ; Fri, 11 Apr 2014 09:46:19 -0700 (PDT) In-Reply-To: <5347E0D4.3040205@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?ISO-8859-15?Q?K=F6nig?= Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Fri, 11 Apr 2014 14:32:20 +0200 Christian K=F6nig wrote: > Anyway, I would do like Ilia suggested and only put the else branch into = > a separate, not inlined function. > = > BTW: It's probably a good idea to do the same for the write function as = > well. I tested it. The majority of the size increase stayed - the else/spinlock part as non-inlined functions, radeon.ko was still 5% larger instead of 7%. - Lauri