From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 02/18] drm/irq: simplify irq checks in drm_wait_vblank Date: Mon, 14 Apr 2014 22:55:32 +0200 Message-ID: <20140414205531.GB9123@mithrandir> References: <1397252175-14227-1-git-send-email-daniel.vetter@ffwll.ch> <1397252175-14227-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1839011189==" Return-path: Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 352626E14B for ; Mon, 14 Apr 2014 13:55:42 -0700 (PDT) Received: by mail-bk0-f54.google.com with SMTP id 6so3158985bkj.27 for ; Mon, 14 Apr 2014 13:55:39 -0700 (PDT) In-Reply-To: <1397252175-14227-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1839011189== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MW5yreqqjyrRcusr" Content-Disposition: inline --MW5yreqqjyrRcusr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 11, 2014 at 11:35:59PM +0200, Daniel Vetter wrote: > Checking for both an irq number _and_ whether it's enabled is > redundant. Originally I've thought the drm_dev_to_irq call would break > drivers which do their own irq checking, but those shouldn't have > DRIVER_HAVE_IRQ set as Thierry Reding pointed out. But such drivers > already need to set dev->irq_enabled for other reasons, so we might as > well ditch that check, too. >=20 > v2: Also drop the HAVE_IRQ check. >=20 > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_irq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding --MW5yreqqjyrRcusr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTTEtDAAoJEN0jrNd/PrOhtD0P/ReAZ59L17gP9LC4/8YztLzR 8FbSEvbf0sQfEAxd0J6O2PTVpaArDsxzhm+qGGfgKZpZS/4vMJ2RwunnLAYjH7SX LLO/HopAGd9C9Er56tcDjCtDQPjPLhy9HYZYMXtCbcLss18CD+WS2cVQI1Vs17oW QXBvONFXeMMntt+NliBzME+aPJEmr/MJ2BS1mPiLfB1KndkqavAWD2sgPHR+vWCi 6tVBgGzBxi2CYCHTYUG7F6I1IeXrTVpIJcvq5pITP6lcyH8oABfQoCHbldLkBXjo c9UZGo1GaqOl2MzIe6Ceh7xuXXU8LhGH2z9MuaC3X6qHKvkQdjqroXfV1lRHU/BM JVJF7a4f/8/eUaQ7dRuXpNcG63HbjP4Me9PCkkDlU4wg7dtjCL2I4yqE4IUs2hWj fbWf1i287HcyG3i3ErmxEa1pkyJOZIQdNbPtva3PMIynS8IRmm1QzyPlzTdVeM23 LKQ7J50OycckZknxgODznZKeOmy9E+z5NJ1sjZk2QWmBborh+Ce3aWioI+owCLad VSt2Mx58FPhWprx2EGAUvCn/eRqgb7YjmYu/DRf/exOLXwcavK0QMZPkwHqR/kQG 3M4eY2f5mwfwWsak8vVnux1xD/EvwRcivUqtbTW0qkzbS/QMTv90GFujL78IgJfK nMF+u7Svl0YFQyd5afqA =7c49 -----END PGP SIGNATURE----- --MW5yreqqjyrRcusr-- --===============1839011189== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1839011189==--