From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 03/18] drm/pci: fold in irq_by_busid support
Date: Thu, 17 Apr 2014 16:33:47 +0200
Message-ID: <20140417143344.GB550@ulmo>
References: <1397252175-14227-1-git-send-email-daniel.vetter@ffwll.ch>
 <1397252175-14227-4-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1387214657=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54])
 by gabe.freedesktop.org (Postfix) with ESMTP id 544A16E2A0
 for <dri-devel@lists.freedesktop.org>; Thu, 17 Apr 2014 07:34:56 -0700 (PDT)
Received: by mail-ee0-f54.google.com with SMTP id d49so763742eek.27
 for <dri-devel@lists.freedesktop.org>; Thu, 17 Apr 2014 07:34:55 -0700 (PDT)
In-Reply-To: <1397252175-14227-4-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org


--===============1387214657==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ADZbWkCsHQ7r3kzd"
Content-Disposition: inline


--ADZbWkCsHQ7r3kzd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 11, 2014 at 11:36:00PM +0200, Daniel Vetter wrote:
[...]
> +int drm_irq_by_busid(struct drm_device *dev, void *data,
> +		     struct drm_file *file_priv)
> +{
> +	struct drm_irq_busid *p = data;
> +
> +	if (drm_core_check_feature(dev, DRIVER_MODESET))
> +		return -EINVAL;
> +
> +	/* UMS was only ever support on pci devices. */

Nit: s/pci/PCI?

> +	if (WARN_ON(!dev->pdev))
> +		return -EINVAL;
> +
> +	if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ))
> +		return -EINVAL;
> +
> +	return drm_pci_irq_by_busid(dev, p);
> +}
> +
> +

Nit: there's a gratuitous blank line introduced here.

Other than that:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--ADZbWkCsHQ7r3kzd
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTT+ZIAAoJEN0jrNd/PrOh37oP/2eFI74C/cBccI8p9Nqy0FM2
hHmWN7tsN9VYc7CITkWJJKS3VxXy2Zs0GxgGNOwf0TeQk8j6Jde846cPRra8FlsV
MWWgBByJOJ3CRwMl0d/T2aRm9kJ1MQc1oicAsdnGmhtoMDlZ3d5x87ZG64U2TX/C
T7lsQ4k3DYpa/t3H0p0GafFVGgbgRY7po6f8Ptk7fMMLeYuJorZC25zHGQ05105B
MDBWGhAWe7x+hCeVogCzzjgVoMCkVoN/cW87vV3XAhlSb8bRGhx25rLxjGUUu6dn
ZdtTza6JkegbBjR3nzFPwz+8Nuh6PoSMv9EUxEDIhthZ3g25T2mD0QPYX4V7yD+Y
PLik0T7XiJURzIgnUgRC/+EK9+pEcrdtG8eF9LkZ3gwp/Fk/W4d8TVfcW/7TB34y
W19nwzJxSB+fkLFPGF8fJcmGEHU37fDlqzaYsYmc9r/26cqHF27Q/s5tr+8wXulL
zRkLaadByac3ZMoiFAJmDoD6wk35MZ0bpYgQStphvggTyX6lxNVVP/m5gnppx5Jy
fbAoEsMWJV1MkFM5Ka1e+QZ0WiTRv1fu+pBpD35RuvMVEolQAv7uC4L0Xco0rcFm
7GB9TZuet6Xha1wCm8hujYLeIaqr2oO6BNyZruCvoPyqfnpMbX+e9oJKcIkJQawR
r4QNtv2A7Yi7epjWDaTi
=l68L
-----END PGP SIGNATURE-----

--ADZbWkCsHQ7r3kzd--

--===============1387214657==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--===============1387214657==--