From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 04/18] drm/irq: drm_control is a legacy ioctl, so pci devices only Date: Thu, 17 Apr 2014 16:38:25 +0200 Message-ID: <20140417143824.GC550@ulmo> References: <1397252175-14227-1-git-send-email-daniel.vetter@ffwll.ch> <1397252175-14227-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0776751812==" Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 78DE46E3BE for ; Thu, 17 Apr 2014 07:39:35 -0700 (PDT) Received: by mail-ee0-f54.google.com with SMTP id d49so768289eek.27 for ; Thu, 17 Apr 2014 07:39:33 -0700 (PDT) In-Reply-To: <1397252175-14227-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0776751812== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YD3LsXFS42OYHhNZ" Content-Disposition: inline --YD3LsXFS42OYHhNZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 11, 2014 at 11:36:01PM +0200, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > index c02b602325cb..4b019646f556 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -386,22 +386,22 @@ int drm_control(struct drm_device *dev, void *data, > * this used to be a separate function in drm_dma.h > */ > =20 > + if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ)) > + return 0; > + if (drm_core_check_feature(dev, DRIVER_MODESET)) > + return 0; > + /* UMS was only ever support on pci devices. */ > + if (WARN_ON(!dev->pdev)) > + return -EINVAL; > =20 > switch (ctl->func) { > case DRM_INST_HANDLER: > - if (!drm_core_check_feature(dev, DRIVER_HAVE_IRQ)) > - return 0; > - if (drm_core_check_feature(dev, DRIVER_MODESET)) > - return 0; > if (dev->if_version < DRM_IF_VERSION(1, 2) && > ctl->irq !=3D drm_dev_to_irq(dev)) > return -EINVAL; > + Nit: This blank line seems unnecessary, but either way: Reviewed-by: Thierry Reding --YD3LsXFS42OYHhNZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTT+dgAAoJEN0jrNd/PrOh5gQP/0ZCzqsKLdOv8OkeUSZX+l2E ohVW3tlTYlrfpyyT7IejmHbQnLVrazWro1iR2zQIJcpbgrByt3Gd++D/n8qVSmc8 LjIb3yC7Sc0zQTmwOactzncZNn6rPKkOUfKZhAvxHXrCLPyWq1cI5cNbAerNHbbN gn6prg8bgI1MKKOGjPAuXQXWQMhaKZ+vibFkGRo6MT+/FJmu7vMHkZKrbBOhawJx rlv2C1M9Z7krxDJ2JyOCCyvHhDKy6MOdJ7iwnOWF3xzHOV3rgfOW6TSZvF1rT50u ja4EfcZUTopCg4sr4hMCIlmFeHchTQoxZSXy8PusnsIzMiTgaXTPNaYAcusejU7/ lM1LAX2Z1nvY29PsQndPVUldUonBolkEcTWSjIA7DBrDoM/JqhxtQFti2sdMzaS+ Bi3vHNpBorh/40ONdpYb/wZxcbf70AkyuQqkqu1uhCvpxzY+4ogt0qagQAJaLKr+ qlECYGAlOOCw/FpiVrK+Uig5QQ61F9silAdBySOhKsYe7sfuNWpdnTyyoIwC8fQA 64LJjec4BjUahOUsV2zSewAErCfO959PjXJPmQyK5isYuiDW/xN0u7d3j6/QALEB OBeBmS7UV8S9e28+1YAYWawvoaD5kmPZfx0KcdvVCmNcIIBn9OtiHNGeOrxm7PBA cVSjOLHT4+RVbD3i0aAw =FgOn -----END PGP SIGNATURE----- --YD3LsXFS42OYHhNZ-- --===============0776751812== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0776751812==--