From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range Date: Thu, 15 May 2014 14:38:47 +0200 Message-ID: <20140515123846.GQ8790@phenom.ffwll.local> References: <1400082072-22482-1-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B7606EE0D for ; Thu, 15 May 2014 05:38:51 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id t10so635360eei.28 for ; Thu, 15 May 2014 05:38:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1400082072-22482-1-git-send-email-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ross Zwisler Cc: Thomas Gleixner , H Peter Anvin , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ingo Molnar List-Id: dri-devel@lists.freedesktop.org On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote: > With this commit: > > 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range > > If clflushopt is available on the system, we use it instead of clflush > in drm_clflush_virt_range. There were two calls to clflush in this > function, but only one was changed to clflushopt. This patch changes > the other clflush call to clflushopt. > > Signed-off-by: Ross Zwisler > Reported-by: Matthew Wilcox > > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Cc: H Peter Anvin > Cc: Ingo Molnar > Cc: Thomas Gleixner Picked to my topic/core-stuff drm branch so it doesn't get lost. -Daniel > > --- > drivers/gpu/drm/drm_cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c > index 534cb89..041b73b 100644 > --- a/drivers/gpu/drm/drm_cache.c > +++ b/drivers/gpu/drm/drm_cache.c > @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length) > char *end = addr + length; > mb(); > for (; addr < end; addr += boot_cpu_data.x86_clflush_size) > - clflush(addr); > + clflushopt(addr); > clflushopt(end - 1); > mb(); > return; > -- > 1.9.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch