From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 02/12] drm: Make the vblank disable timer
	per-crtc
Date: Wed, 21 May 2014 13:17:49 +0200
Message-ID: <20140521111747.GD2014@ulmo>
References: <1400093477-3217-1-git-send-email-daniel.vetter@ffwll.ch>
 <1400093477-3217-3-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1782448347=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1400093477-3217-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org


--===============1782448347==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="9dgjiU4MmWPVapMU"
Content-Disposition: inline


--9dgjiU4MmWPVapMU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 14, 2014 at 08:51:04PM +0200, Daniel Vetter wrote:
> From: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
>=20
> Currently there's one per-device vblank disable timer, and it gets
> reset wheneven the vblank refcount for any crtc drops to zero. That

"whenever"

> means that one crtc could accidentally be keeping the vblank interrupts
> for other crtcs enabled even if there are no users for them. Make the
> disable timer per-crtc to avoid this issue.

Very pedantically: s/crtc/CRTC/ and maybe even s/vblank/VBLANK/. Feel
free to ignore those, though. =3D)

Also, and I may have asked before, why do we even need this timer? Why
not simply disable interrupts when the last vblank reference goes away?

Generally, though:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--9dgjiU4MmWPVapMU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTfItbAAoJEN0jrNd/PrOhL+gQAKCoVYIcwtfWhPl/Nm64UbHk
uJuwxtanWuAIujeGuTixq/0Vj7KR/dVNnocujl2NW23knt/AgIK8/4cGtMD8QgQl
pzbulaC5PqhTaiSCXi8uzSX2ZJtMsslseiYFfAfB+x48y64ff9CXovYMHbf1th4P
4PFHWTowK+PWntfV3v8vdBptWJZrIYbhGprsoEBzs6xsqT2QJTRc5+HzuSXj8wB0
YiAsaiF42qo6T778fSBcxHiK3F3JjA8V63GMqJLd79/GmCRc9IuBBRE+QeOViwAV
YF7snC4u1yDMmMwDH+J4UmIUz/lWQvgY3LN/ZLjAKA+EEW7y7MHd8H73BCuOfAwb
wb0MzJBLW9jxiTq43StAcvj03jNH2D4nAIvOmq/LsuqJVHpYk+2+534eia2VV5Qm
9L8H5UoCeLX6aq5yQaCEy6RSo8TsJfpcxYxgJWMJipVImAabq14rpf56RkGXmp4b
tu60GB5HwUhPYvLhUf/KcbQ5zpJhLc860Ed76Ww2W83B0MMcLJZEx/wMcEd84AY+
B2qpwvlqM3NpjSpr81qQqZZsWwR2iewcR3+bD35h/7j1MyaL7teTEEL+uI50vCOj
vqYOP/LOCTIwr2jDDZoL6Trz9LbaZtsqVvIjnYtJazgl4Yr6C5CvX2ZFx9ROb8dv
/IWgeNUUNv1hilm25r/Q
=UlvU
-----END PGP SIGNATURE-----

--9dgjiU4MmWPVapMU--

--===============1782448347==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1782448347==--