From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 03/12] drm: Make blocking vblank wait return when the vblank interrupts get disabled Date: Wed, 21 May 2014 13:20:55 +0200 Message-ID: <20140521112053.GE2014@ulmo> References: <1400093477-3217-1-git-send-email-daniel.vetter@ffwll.ch> <1400093477-3217-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1951470317==" Return-path: In-Reply-To: <1400093477-3217-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1951470317== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="so9zsI5B81VjUb/o" Content-Disposition: inline --so9zsI5B81VjUb/o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 14, 2014 at 08:51:05PM +0200, Daniel Vetter wrote: > From: Ville Syrj=C3=A4l=C3=A4 >=20 > If there's a blocking vblank wait in progress while the vblank interrupt > gets disabled, the current code will just let the vblank wait time out. > Instead make it return immediately when vblank interrupts get disabled. Can this even happen? drm_wait_vblank() takes a vblank reference earlier and drops it right before returning. But perhaps this will become obvious since from a quick peek some of the subsequent patches seem like they will make it possible to force VBLANK off? Thierry --so9zsI5B81VjUb/o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTfIwVAAoJEN0jrNd/PrOhbicP/j6EQFP/+ML1u09TB1rgJ6S0 eIwSjJP5AdEw2JXuGWMnH6yVXKndCIf4OCllONbOwdfsZuNtwjRL4JiqAEZxS8d0 17EbW39Yg486H5pnfiNfJHIi46X1k8eFKDLNt9yMoBypnP/2BFJh+9k3By1xXGNR c8rDSlk3hWbickL6nhikMrFkXLqjm2o84NUdshpgRSE+KtwY6GRu+7Vcf453mL0R bfEIc4dQeKXtfRPhQO+z7S4MLkYfZECShk2EfNQOkepsR2ZRdXJwM2yvoAvIQ3qm 8XyIyGg3GutwH/iU7Wy2FRcy0Rqs30bQ3/JQY7khP9On6I3+GkuohtvQXtNrrj7u XavU0LyYUjyG5RwTERFSOR2vPlBDzF9HE65ddYYOG3Lm1Pt36MDKmvhReyNJlV1Y qNF0vDXfVSu6MiTI4fj6hdSzv8iTScipF4YHIPu8I3S5UHo21GLiY12gYtwNR+uT DJoaQNYuHBpyyiF1LRpec8UCAuke7h6xR3LKegSrVvMF3Veqjv828Hf/yjgWxsGP Xlv+xSXe1gjP/Wzw/0ifiBpXv5X80vPKYKhBt6RMML1GZrLsjzQsso5buWOteMaA +Or5PW/qiXGeOpZK+jxulu3BfGI0j/PaccDY5+R3FsWzJtBBpysclmiDR9kseB82 CTEyYZMi7/0chPAz2LeH =GOB9 -----END PGP SIGNATURE----- --so9zsI5B81VjUb/o-- --===============1951470317== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1951470317==--