From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 03/12] drm: Make blocking vblank wait return when the vblank interrupts get disabled Date: Wed, 21 May 2014 13:24:20 +0200 Message-ID: <20140521112416.GF2014@ulmo> References: <1400093477-3217-1-git-send-email-daniel.vetter@ffwll.ch> <1400093477-3217-4-git-send-email-daniel.vetter@ffwll.ch> <20140521112053.GE2014@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0591361791==" Return-path: In-Reply-To: <20140521112053.GE2014@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0591361791== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vA66WO2vHvL/CRSR" Content-Disposition: inline --vA66WO2vHvL/CRSR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 21, 2014 at 01:20:55PM +0200, Thierry Reding wrote: > On Wed, May 14, 2014 at 08:51:05PM +0200, Daniel Vetter wrote: > > From: Ville Syrj=C3=A4l=C3=A4 > >=20 > > If there's a blocking vblank wait in progress while the vblank interrupt > > gets disabled, the current code will just let the vblank wait time out. > > Instead make it return immediately when vblank interrupts get disabled. >=20 > Can this even happen? drm_wait_vblank() takes a vblank reference earlier > and drops it right before returning. But perhaps this will become > obvious since from a quick peek some of the subsequent patches seem like > they will make it possible to force VBLANK off? Ah, it seems like drm_vblank_off() can already do exactly that, in which case this makes sense: Reviewed-by: Thierry Reding --vA66WO2vHvL/CRSR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTfIzgAAoJEN0jrNd/PrOhXZUQALNIFpNRrIVqL9g9bWIqjUBQ 3Qnn6UA5oF3ikQNwGgE7JHMi8bEpAZf1ZavfA6CUvBPRP2R0rDF77FeIuVhCKq6p M8rRppgRA/dnj3ooY++gPnh3Z5VKmshPfq/8C0wnLA/axpw4tIIMtseHWWtFyXtr ZNaA8xdVjpJ2LltrLymXAy+2iZjEx6lrZ7sNnGDMfYA34ZkLIeIp+zORHCa5K1AL rpgshT26roZuy3vlQA+5Hq7oWNikRk0BI31PvteaJDIlKOx3D4HXpytUAcm2O97e xC6Tw7atxwiubALHB4j4XKuC0o/VbFG/kf9JaXXXdz02Hn9I/KlXMo75ABl23TQy nPU3VB7G0YMsJ5ultVhhhQIyTrnh0sZ5i0IGG+qGc/YPZK6zLjf+jF5/U6kC9UwH akf0lJcMUOqYTfr46aw3vN1EeKuoVuOJHtb6xkcTeQtLdAzGNeNw1LaNXqcGXQoq 8qxSRuYBSKv5crZzWRl3uxp1Q/35ZACJnVU4Ru9IM57Kwqnt9ConFCkyBi2Rl8NA /SyMEf7COQmekPRJ9RiTrSnmQODolceokqK4k86ege0q8gOIzlIZE95dok1fD8hs aJQeHSyDv+ok3oTPB/vNKbzqoUGlzUkLLas6cMGOM2dt995mzouEyEMdfLkBfGYC 53tCorsp9fd2FDrylWyl =hIhY -----END PGP SIGNATURE----- --vA66WO2vHvL/CRSR-- --===============0591361791== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0591361791==--