From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM Date: Wed, 21 May 2014 14:49:05 +0200 Message-ID: <20140521124904.GI2014@ulmo> References: <1400093477-3217-1-git-send-email-daniel.vetter@ffwll.ch> <1400093477-3217-10-git-send-email-daniel.vetter@ffwll.ch> <20140520120341.GF27580@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1481754622==" Return-path: In-Reply-To: <20140520120341.GF27580@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1481754622== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cf0hFtnykp6aONGL" Content-Disposition: inline --cf0hFtnykp6aONGL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrj=C3=A4l=C3=A4 wrote: > On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote: > > Now that we unconditionally dtrt when disabling/enabling crtcs we > > don't need any hacks any longer to keep the vblank logic sane when > > all the registers go poof. So let's rip it all out. >=20 > Hmm. drm_update_vblank_count() will now see some kind of diff between > the last and current value when the registers got cloberred. So the > vblank counter reported to userspace will jump. But I guess that's fine > as long as userspace realizes that the counter is not at all reliable > across modesets. I think that's a fair assumption. Modeset is kind of a heavy operation and I wouldn't expect applications to perform one all that often. That should be even more true of applications that rely on the counters. At least that would be my expectation. Thierry --cf0hFtnykp6aONGL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTfKC/AAoJEN0jrNd/PrOh6lgQAMGlm1vRlJQbSBUVjjXSIU4B U3+obko1VkjZFbP8IIUFKI3kFfPVri6TvE9sROYsnQEJ1E2Uj57xzCthGVvHrxtf taiCQb8ZGKQOqnriZuexNEONqp6DX4IQvT8/rNg/oAvgQqkND1nGp1n2McAWc4EX wDxgurb17wjDGBUGaTPAEC8KlwNtnf+MPIpCdfl0alzOFzAKYo4WFD3JUjgGu/sT dBfZpE0s+eMq0ii1HvXcvAHSoXm6jMm8ySsjZboKG9V4bE3SwsmeYn5BbbwKtn3h p9LmV6htSK/yp3QwuCtgufbl4G4jwZ4c6vSt4cZyyiQGvYmPpQCBigLRE+WxDqpC hkgmzf3TnSc0cOy/3k6hfVeOSpWLkEg7eAC8c1r27+CmFqdsgRHUPgcBrI986LF2 vqL4XGEyPRiWj8EIi1H4gejaBtea3Ji2kSP+dB8UFbU4IvIflw+92U7DaXx2Nw9d ZUDoIxbxV500V+CJWCXz6VepjMMQOqTS+E2vPnJ9qBmb7KchqbPdobzlw1e4WxPt xb4MryYM6V1K/wcKkoGbPtYeF+tGCew8/uO/3MuAvE5+mWvOsWIUfP0j2YZTqFQw El+R4CzkfuoWUAyoTO3dENZkXDP7xd70ouNfglYLuwMDNueHib8CUQqF/Nqnh1Us 2XjEGLsICX4Fa1WeumJF =4i2N -----END PGP SIGNATURE----- --cf0hFtnykp6aONGL-- --===============1481754622== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1481754622==--