From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 11/12] [RFC] drm/irq: More robustness in drm_vblank_on|off Date: Wed, 21 May 2014 15:11:30 +0200 Message-ID: <20140521131130.GF14357@phenom.ffwll.local> References: <1400093477-3217-1-git-send-email-daniel.vetter@ffwll.ch> <1400093477-3217-15-git-send-email-daniel.vetter@ffwll.ch> <20140521125259.GK2014@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id E228F6EA4A for ; Wed, 21 May 2014 06:11:34 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id e51so1530039eek.24 for ; Wed, 21 May 2014 06:11:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140521125259.GK2014@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, May 21, 2014 at 02:53:00PM +0200, Thierry Reding wrote: > On Wed, May 14, 2014 at 08:51:16PM +0200, Daniel Vetter wrote: > > If we want to use this functionality in generic helpers to make > > sure that all drivers have somewhat sane vblank handling across > > modesets/dpms, we need to make it work for all drivers. But some > > don't support interrupts and hence also not vblank waits. > > > > Just return early on such drivers. > > > > Note that with pageflips drivers are free to implement them however > > they wish to. > > > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/drm_irq.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > I'm confused. This seems to be the very same patch as 09/12. But since > you've already merged this I guess it must have resolved itself > somehow... Screwed up the patch sending and submitted two patch 09/12. This one really is just rfc and I didn't pull it in yet. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch