From mboxrd@z Thu Jan  1 00:00:00 1970
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH 2/5] drm/armada: use shmem helpers if possible
Date: Sun, 25 May 2014 23:56:04 +0100
Message-ID: <20140525225603.GA3693@n2100.arm.linux.org.uk>
References: <1401021252-29006-1-git-send-email-dh.herrmann@gmail.com>
 <1401021252-29006-2-git-send-email-dh.herrmann@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from pandora.arm.linux.org.uk (gw-1.arm.linux.org.uk [78.32.30.217])
 by gabe.freedesktop.org (Postfix) with ESMTP id E62F56E127
 for <dri-devel@lists.freedesktop.org>; Sun, 25 May 2014 15:57:27 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1401021252-29006-2-git-send-email-dh.herrmann@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>, Dave Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Sun, May 25, 2014 at 02:34:09PM +0200, David Herrmann wrote:
> shmem_read_mapping_page() uses mapping_gfp_mask(mapping) as default gfp
> mask. No reason to use shmem_read_mapping_page_gfp() directly if we want
> the default behavior.
> 
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>

Nothing obviously wrong and looks sane enough.

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks.

Airlied, can you take this one as well please?  Thanks.

> ---
>  drivers/gpu/drm/armada/armada_gem.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
> index 887816f..bb9b642 100644
> --- a/drivers/gpu/drm/armada/armada_gem.c
> +++ b/drivers/gpu/drm/armada/armada_gem.c
> @@ -433,7 +433,6 @@ armada_gem_prime_map_dma_buf(struct dma_buf_attachment *attach,
>  
>  	if (dobj->obj.filp) {
>  		struct address_space *mapping;
> -		gfp_t gfp;
>  		int count;
>  
>  		count = dobj->obj.size / PAGE_SIZE;
> @@ -441,12 +440,11 @@ armada_gem_prime_map_dma_buf(struct dma_buf_attachment *attach,
>  			goto free_sgt;
>  
>  		mapping = file_inode(dobj->obj.filp)->i_mapping;
> -		gfp = mapping_gfp_mask(mapping);
>  
>  		for_each_sg(sgt->sgl, sg, count, i) {
>  			struct page *page;
>  
> -			page = shmem_read_mapping_page_gfp(mapping, i, gfp);
> +			page = shmem_read_mapping_page(mapping, i);
>  			if (IS_ERR(page)) {
>  				num = i;
>  				goto release;
> -- 
> 1.9.3
> 

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.