From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm: crtc-helper: Remove useless loop
Date: Wed, 28 May 2014 15:36:38 +0200
Message-ID: <20140528133638.GV14841@phenom.ffwll.local>
References: <1401281016-4874-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-we0-f171.google.com (mail-we0-f171.google.com
 [74.125.82.171])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1BB6D6E598
 for <dri-devel@lists.freedesktop.org>; Wed, 28 May 2014 06:36:43 -0700 (PDT)
Received: by mail-we0-f171.google.com with SMTP id w62so11151105wes.2
 for <dri-devel@lists.freedesktop.org>; Wed, 28 May 2014 06:36:43 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1401281016-4874-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:
> Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
> disable disconnected outputs") made the for each loop over connectors
> empty in __drm_helper_disable_unused_functions(). Remove the loop
> altogether.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Isn't the local variable connector now unused? At least that's what my old
patch did:

http://patchwork.freedesktop.org/patch/24184/

/me looks at Dave ...

Cheers, Daniel
> ---
>  drivers/gpu/drm/drm_crtc_helper.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index df281b5..fbc3aa7 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -145,11 +145,6 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev)
>  
>  	drm_warn_on_modeset_not_all_locked(dev);
>  
> -	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
> -		if (!connector->encoder)
> -			continue;
> -	}
> -
>  	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
>  		if (!drm_helper_encoder_in_use(encoder)) {
>  			drm_encoder_disable(encoder);
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch