From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3
Date: Wed, 11 Jun 2014 08:41:13 -0700
Message-ID: <20140611084113.4c1089af@jbarnes-desktop>
References: <1401992671-2548-1-git-send-email-jbarnes@virtuousgeek.org>
 <1401992671-2548-2-git-send-email-jbarnes@virtuousgeek.org>
 <20140610140251.GP5821@phenom.ffwll.local>
 <20140610102711.171104dc@jbarnes-desktop>
 <20140610193326.GB5821@phenom.ffwll.local>
 <20140610124538.350e86ba@jbarnes-desktop>
 <CAKMK7uF13z2dT9_C5KEDZX=WVRMDV84_xPkn8sGRtuJGcFwxng@mail.gmail.com>
 <20140611081345.2d805e8c@jbarnes-desktop>
 <CAKMK7uGjCQVcyq_y0hzKUEN-rpcn08KcyANjFR7fcSix4ZLHxA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <CAKMK7uGjCQVcyq_y0hzKUEN-rpcn08KcyANjFR7fcSix4ZLHxA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Wed, 11 Jun 2014 17:39:29 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, Jun 11, 2014 at 5:13 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >> - If you have a machine which uses tiled framebuffers and enables
> >>   swizzling in the BIOS your code will a) drop the swizzle setup in
> >>   gem_init_hw, breaking resume b) not set the swizzle settings correctly
> >>   in swizzle_detect, breaking swap in/out and pwrite/pread. Not sure such
> >>   a machine exists, but still.
> >
> > This would affect krh's MBA, which is why I wanted testing here...
> > anyway I'll spin a new one and ask krh to test again.
> 
> Hm, I've thought the issue with the MBA is that it used tiled fbs, but
> non-swizzled. And then a mess ensued when we've enabled it. But yeah,
> unfortunately with the new logic we need to retest :(

Ah yeah I think you're right, either way, need more testing.

Maybe we should have just gone with the first patch to never enable
swizzling based on Art's assertion that it didn't matter.

-- 
Jesse Barnes, Intel Open Source Technology Center