From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 2/2] drm/panel: make DRM_PANEL_LD9040 depend on SPI Date: Fri, 13 Jun 2014 15:17:58 +0200 Message-ID: <20140613131758.GB5568@ulmo> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1919426789==" Return-path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by gabe.freedesktop.org (Postfix) with ESMTP id C15026EA21 for ; Fri, 13 Jun 2014 06:21:02 -0700 (PDT) Received: by mail-we0-f169.google.com with SMTP id t60so2834181wes.28 for ; Fri, 13 Jun 2014 06:21:01 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King Cc: Andrzej Hajda , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1919426789== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eJnRUKwClWJh1Khz" Content-Disposition: inline --eJnRUKwClWJh1Khz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 13, 2014 at 02:06:16PM +0100, Russell King wrote: > Rather than DRM_PANEL_LD9040 selecting SPI, which then results in an > increase in the probability of Kconf reporting circular dependencies > (we're one "select" away from that right now), make this depend on > SPI instead. This is akin to having some driver select DRM. >=20 > Having some drivers depend on a subsystem, and other drivers select a > subsystem is a recipe for circular dependencies, and there's really no > need for it. >=20 > The potential circular dependency (which can be caused today by the > addition of selecting DRM_PANEL from DRM_IMX_LDB) is: >=20 > symbol DMADEVICES is selected by SAMSUNG_DMADEV > symbol SAMSUNG_DMADEV is selected by S3C64XX_PL080 > symbol S3C64XX_PL080 is selected by SPI_S3C64XX > symbol SPI_S3C64XX depends on SPI > symbol SPI is selected by DRM_PANEL_LD9040 > symbol DRM_PANEL_LD9040 depends on DRM_PANEL > symbol DRM_PANEL is selected by DRM_IMX_LDB > symbol DRM_IMX_LDB depends on MFD_SYSCON > symbol MFD_SYSCON is selected by POWER_RESET_KEYSTONE > symbol POWER_RESET_KEYSTONE depends on POWER_SUPPLY > symbol POWER_SUPPLY is selected by HID_SONY > symbol HID_SONY depends on NEW_LEDS > symbol NEW_LEDS is selected by BACKLIGHT_ADP8860 > symbol BACKLIGHT_ADP8860 depends on BACKLIGHT_CLASS_DEVICE > symbol BACKLIGHT_CLASS_DEVICE is selected by FB_MX3 > symbol FB_MX3 depends on MX3_IPU > symbol MX3_IPU depends on DMADEVICES >=20 > Acked-by: Arnd Bergmann > Signed-off-by: Russell King > --- > drivers/gpu/drm/panel/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. Thierry --eJnRUKwClWJh1Khz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTmvoFAAoJEN0jrNd/PrOh5DMQAKNfgluAURyIWYNPPi8MBl9B Y4hB6v101550xxkWUTs/pbnMQuw47FmFso8OPf6XNxFZ44qrQOJEtn08ySPH8192 hfhNzuAuRf0rhUiTNFDsRWl/iUE43tEUKgqkLC+dzDi8t6Ia3T2LVLwJSiN3w/dR 3Ph4tsJ46jY1VGg3ZvVWGbjmJKFWfizVFypXV+oPCcRDAkaseUreK3nxLXxjwAIp ExTmjXCDyNd+nxglGqymwfX+5VuISqKvk0izje67s4A+M8BlPIxqh1dA0v7CveQM Pl5aUhcKSQB1ZfIX57GDQelK9VqERE+waKz6FVlTbAhUGBWY6zXTzjEDwLDsbIvf jEZTGAeGYKlhXXuD/QFjYi6bEDrrhYNN9tssuOXa4snF/s7nlV2k3equXmgPMJ7a jcAA1GB38z62VDE9X2vJa3E9h+tdUvh+gqG/kmhCJvzsQqrAu9ojpQm5ZAkm/PC1 ISp+K1BDvjgFcqQXO1f0CIQbZjvc//wYHVorMqKCdI9SgMbJQVwbemPH/RomJL+4 UC9e/QXCuDqRJV1TjZahCv8vXEOk1yMWjl0EGFHNYzy22a1BxHnPoYH/GaJJy45q +EudUKygYoEi4pwyAcq3hueqExNlovbHfq84Av7pRSz062CsTV/IcsZUK3em6B8o 84/a/QE+Zo1vBItRh0Ot =ivCE -----END PGP SIGNATURE----- --eJnRUKwClWJh1Khz-- --===============1919426789== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1919426789==--