From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: add register and unregister functions for connectors Date: Thu, 19 Jun 2014 08:57:21 +0200 Message-ID: <20140619065721.GM5821@phenom.ffwll.local> References: <1401379063-15375-1-git-send-email-thomas.wood@intel.com> <1401379063-15375-2-git-send-email-thomas.wood@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: David Herrmann Cc: Daniel Vetter , Intel Graphics Development , Thomas Wood , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 10, 2014 at 06:21:35PM +0200, David Herrmann wrote: > Hi > > On Thu, May 29, 2014 at 5:57 PM, Thomas Wood wrote: > > Introduce generic functions to register and unregister connectors. This > > provides a common place to add and remove associated user space > > interfaces. > > > > Signed-off-by: Thomas Wood > > --- > > Documentation/DocBook/drm.tmpl | 6 +++--- > > drivers/gpu/drm/armada/armada_output.c | 4 ++-- > > drivers/gpu/drm/ast/ast_mode.c | 4 ++-- > > drivers/gpu/drm/bridge/ptn3460.c | 2 +- > > drivers/gpu/drm/drm_crtc.c | 30 ++++++++++++++++++++++++++- > > drivers/gpu/drm/drm_sysfs.c | 2 -- > > drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +- > > drivers/gpu/drm/exynos/exynos_drm_connector.c | 6 +++--- > > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 4 ++-- > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- > > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 +- > > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > > drivers/gpu/drm/gma500/cdv_intel_crt.c | 4 ++-- > > drivers/gpu/drm/gma500/cdv_intel_dp.c | 4 ++-- > > drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 4 ++-- > > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 4 ++-- > > drivers/gpu/drm/gma500/mdfld_dsi_output.c | 4 ++-- > > drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +- > > drivers/gpu/drm/gma500/oaktrail_lvds.c | 2 +- > > drivers/gpu/drm/gma500/psb_intel_lvds.c | 4 ++-- > > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 4 ++-- > > drivers/gpu/drm/i915/intel_crt.c | 2 +- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- > > drivers/gpu/drm/i915/intel_dsi.c | 2 +- > > drivers/gpu/drm/i915/intel_dvo.c | 2 +- > > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > > drivers/gpu/drm/i915/intel_lvds.c | 2 +- > > drivers/gpu/drm/i915/intel_sdvo.c | 10 ++++----- > > drivers/gpu/drm/i915/intel_tv.c | 2 +- > > drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- > > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 4 ++-- > > drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++-- > > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++-- > > drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- > > drivers/gpu/drm/radeon/radeon_connectors.c | 6 +++--- > > drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 4 ++-- > > drivers/gpu/drm/rcar-du/rcar_du_vgacon.c | 4 ++-- > > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 6 +++--- > > drivers/gpu/drm/tegra/output.c | 4 ++-- > > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > > drivers/gpu/drm/tilcdc/tilcdc_slave.c | 2 +- > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 2 +- > > drivers/gpu/drm/udl/udl_connector.c | 4 ++-- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 +- > > drivers/staging/imx-drm/imx-drm-core.c | 6 +++--- > > You even caught imx.. and you removed the EXPORT_SYMBOL. So looks all > good to me. > I like that refactoring and I don't think we need an ACK from all > driver authors. This is: > > Reviewed-by: David Herrmann > > Maybe Daniel or Dave can pick this up? I've pulled in all three patches into my topic/core-stuff branch and will send a pull request to Dave once drm-next is open. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch