From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/fb-helper: Redundant info->fix.type_aux setting in drm_fb_helper_fill_fix() Date: Thu, 19 Jun 2014 09:16:46 +0200 Message-ID: <20140619071646.GP5821@phenom.ffwll.local> References: <1403162077-3065-1-git-send-email-Ying.Liu@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DB916E102 for ; Thu, 19 Jun 2014 00:16:54 -0700 (PDT) Received: by mail-wg0-f44.google.com with SMTP id x13so1850803wgg.27 for ; Thu, 19 Jun 2014 00:16:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1403162077-3065-1-git-send-email-Ying.Liu@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liu Ying Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Jun 19, 2014 at 03:14:37PM +0800, Liu Ying wrote: > The variable info->fix.type_aux is set to zero twice in the function > drm_fb_helper_fill_fix(). This patch removes one redundant. > > Signed-off-by: Liu Ying Merged into my topic/core-stuff branch, will show up in 3.17. -Daniel > --- > drivers/gpu/drm/drm_fb_helper.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 8daa4ad..142c39c 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -1056,7 +1056,6 @@ void drm_fb_helper_fill_fix(struct fb_info *info, uint32_t pitch, > info->fix.ypanstep = 1; /* doing it in hw */ > info->fix.ywrapstep = 0; > info->fix.accel = FB_ACCEL_NONE; > - info->fix.type_aux = 0; > > info->fix.line_length = pitch; > return; > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch