From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Nikula, Jani" <jani.nikula@linux.intel.com>,
Dave Airlie <airlied@linux.ie>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()
Date: Thu, 19 Jun 2014 16:42:19 +0200 [thread overview]
Message-ID: <20140619144219.GB12390@t400> (raw)
In-Reply-To: <CAKMK7uEbtqa3uF82CwnD4mBYfOsFpGO-Cm94_U2UFw7orTULnA@mail.gmail.com>
On 06/19, Daniel Vetter wrote:
> On Thu, Jun 19, 2014 at 4:35 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > The actual bug we seem to have is blowing up on the ggtt_unpin in
> > context_fini. Which is doubly-impossible: Gen4 doesn't have hw
> > contexts, so should have dctx->obj == NULL. And ring init failures
> > fail earlier so shouldn't even hit the context_fini code below the
> > cleanup_gem: label in driver_load. Seriously confused here.
>
> Also please retest with latest upstream, we've made the ring init
> failure non-letal for the driver. That should help you, too.
> -Daniel
Thanks for comments and I will resubmit the patch, still it is better
to have it.
/Konrad
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-06-19 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 22:38 [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common() Konrad Zapalowicz
2014-06-19 6:15 ` Daniel Vetter
2014-06-19 12:45 ` Konrad Zapalowicz
2014-06-19 14:35 ` Daniel Vetter
2014-06-19 14:36 ` Daniel Vetter
2014-06-19 14:42 ` Konrad Zapalowicz [this message]
2014-06-19 17:07 ` [PATCH v2] " Konrad Zapalowicz
2014-06-19 19:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619144219.GB12390@t400 \
--to=bergo.torino@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox