From mboxrd@z Thu Jan  1 00:00:00 1970
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH RFC v2 3/8] component: add support for component match
 array
Date: Thu, 26 Jun 2014 15:46:01 +0100
Message-ID: <20140626144601.GS32514@n2100.arm.linux.org.uk>
References: <20140624192830.GC20555@n2100.arm.linux.org.uk>
 <E1WzWOy-0007zc-36@rmk-PC.arm.linux.org.uk>
 <CA+gwMcdO5P-Yu+-FeHHGxkKwObsATL-ThVDwmEm2_cZ3enUXPQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from pandora.arm.linux.org.uk (gw-1.arm.linux.org.uk [78.32.30.217])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4C7596E0A8
 for <dri-devel@lists.freedesktop.org>; Thu, 26 Jun 2014 07:46:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gwMcdO5P-Yu+-FeHHGxkKwObsATL-ThVDwmEm2_cZ3enUXPQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
List-Id: dri-devel@lists.freedesktop.org

On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> Hi Russell,
> 
> On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> <rmk+kernel@arm.linux.org.uk> wrote:
> [...]
> > +/*
> > + * Add a component to be matched.
> > + *
> > + * The match array is first created or extended if necessary.
> > + */
> > +void component_match_add(struct device *dev, struct component_match **matchptr,
> > +       int (*compare)(struct device *, void *), void *compare_data)
> > +{
> > +       struct component_match *match = *matchptr;
> > +
> > +       if (IS_ERR(match))
> > +               return;
> > +
> > +       if (!match || match->num == match->alloc) {
> > +               size_t new_size = match ? match->alloc + 16 : 15;
> > +
> > +               match = component_match_realloc(dev, match, new_size);
> > +
> > +               *matchptr = match;
> > +
> > +               if (IS_ERR(match))
> > +                       return;
> > +       }
> > +
> > +       match->compare[match->num].fn = compare;
> > +       match->compare[match->num].data = compare_data;
> > +       match->num++;
> > +}
> 
> component_match_add should be exported.

Fixed, thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.