dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [v2 11/11] drm: Resetting rotation property
Date: Fri, 4 Jul 2014 16:19:11 +0100	[thread overview]
Message-ID: <20140704151911.GI7634@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1404467043-5072-12-git-send-email-sonika.jindal@intel.com>

On Fri, Jul 04, 2014 at 03:14:03PM +0530, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
> 
> Reset rotation property to 0 wherever applicable
> 
> v2: Also calling set_property of the plane to set the rotation in the plane
> structure.
> 
> Cc: damien.lespiau@intel.com
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

> ---
>  drivers/gpu/drm/drm_fb_helper.c |   16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index d5d8cea..30806b4 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -282,9 +282,23 @@ static bool restore_fbdev_mode(struct drm_fb_helper *fb_helper)
>  
>  	drm_warn_on_modeset_not_all_locked(dev);
>  
> -	list_for_each_entry(plane, &dev->mode_config.plane_list, head)
> +	list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
> +
> +		if (plane->rotation_property) {
> +			int ret = 0;
> +			if (plane->funcs->set_property)
> +				ret = plane->funcs->set_property(plane,
> +					plane->rotation_property,
> +					BIT(DRM_ROTATE_0));
> +			if (!ret)
> +				drm_object_property_set_value(&plane->base,
> +					plane->rotation_property,
> +					BIT(DRM_ROTATE_0));
> +		}
> +
>  		if (plane->type != DRM_PLANE_TYPE_PRIMARY)
>  			drm_plane_force_disable(plane);
> +	}
>  
>  	for (i = 0; i < fb_helper->crtc_count; i++) {
>  		struct drm_mode_set *mode_set = &fb_helper->crtc_info[i].mode_set;
> -- 
> 1.7.10.4
> 

  reply	other threads:[~2014-07-04 15:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04  9:43 [v2 00/11] Support for 180 degree HW rotation sonika.jindal
2014-07-04  9:43 ` [v2 01/11] drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h sonika.jindal
2014-07-04  9:43 ` [v2 02/11] drm: Add support_bits parameter to drm_property_create_bitmask() sonika.jindal
2014-07-04  9:43 ` [v2 03/11] drm: Add drm_mode_create_rotation_property() sonika.jindal
2014-07-04  9:43 ` [v2 04/11] drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() sonika.jindal
2014-07-04  9:43 ` [v2 05/11] drm: Add drm_rect rotation functions sonika.jindal
2014-07-04  9:43 ` [v2 06/11] drm: Add drm_rotation_simplify() sonika.jindal
2014-07-04  9:43 ` [v2 07/11] drm/i915: Add 180 degree sprite rotation support sonika.jindal
2014-07-04  9:44 ` [v2 08/11] drm/i915: Make intel_plane_restore() return an error sonika.jindal
2014-07-04  9:44 ` [v2 09/11] drm/i915: Add rotation property for sprites sonika.jindal
2014-07-04  9:44 ` [v2 10/11] drm/i915: Add 180 degree primary plane rotation support sonika.jindal
2014-07-04 14:58   ` Damien Lespiau
2014-07-06  8:08     ` Jindal, Sonika
2014-07-07  5:31     ` [PATCH] " sonika.jindal
2014-07-04  9:44 ` [v2 11/11] drm: Resetting rotation property sonika.jindal
2014-07-04 15:19   ` Damien Lespiau [this message]
2014-07-04 15:06 ` [v2 00/11] Support for 180 degree HW rotation Damien Lespiau
2014-07-06  8:11   ` Jindal, Sonika
2014-07-07 13:38     ` Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140704151911.GI7634@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sonika.jindal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox