From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <deathsimple@vodafone.de>
Cc: jglisse@redhat.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/radeon: add userptr support v5
Date: Mon, 28 Jul 2014 17:27:41 +0200 [thread overview]
Message-ID: <20140728152741.GE4747@phenom.ffwll.local> (raw)
In-Reply-To: <1406547012-3105-1-git-send-email-deathsimple@vodafone.de>
On Mon, Jul 28, 2014 at 01:30:08PM +0200, Christian König wrote:
> +struct dma_buf *radeon_gem_prime_export(struct drm_device *dev,
> + struct drm_gem_object *gobj,
> + int flags)
> +{
> + struct radeon_bo *bo = gem_to_radeon_bo(gobj);
> + if (radeon_ttm_tt_has_userptr(bo->tbo.ttm))
> + return ERR_PTR(-EPERM);
dma-buf is used by wayland and dri3, so this won't cut it. Instead you
need to reject any real device attachments with a special ->attach
callback to make sure that dma-bufs are still useful as buffer cookies,
but not for actual cross-device sharing.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-28 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 11:30 [PATCH 1/5] drm/radeon: add userptr support v5 Christian König
2014-07-28 11:30 ` [PATCH 2/5] drm/radeon: add userptr flag to limit it to anonymous memory Christian König
2014-07-28 11:30 ` [PATCH 3/5] drm/radeon: add userptr flag to directly validate the BO to GTT Christian König
2014-07-28 11:30 ` [PATCH 4/5] drm/radeon: add userptr flag to register MMU notifier Christian König
2014-07-28 11:30 ` [PATCH 5/5] drm/radeon: allow userptr write access under certain conditions Christian König
2014-07-28 15:27 ` Daniel Vetter [this message]
2014-07-29 8:11 ` [PATCH 1/5] drm/radeon: add userptr support v5 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728152741.GE4747@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox