dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <j.glisse@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: tweak ACCEL_WORKING2 query for hawaii
Date: Tue, 29 Jul 2014 11:39:14 -0400	[thread overview]
Message-ID: <20140729153913.GA3103@gmail.com> (raw)
In-Reply-To: <1406644398-2191-1-git-send-email-alexander.deucher@amd.com>

On Tue, Jul 29, 2014 at 10:33:18AM -0400, Alex Deucher wrote:
> Return 2 so we can be sure the kernel has the necessary
> changes for acceleration to work.

I highly dislike that ? Why about just using nop2 in userspace ?

> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_kms.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
> index 35d9318..dcec4ff 100644
> --- a/drivers/gpu/drm/radeon/radeon_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> @@ -254,7 +254,14 @@ static int radeon_info_ioctl(struct drm_device *dev, void *data, struct drm_file
>  		}
>  		break;
>  	case RADEON_INFO_ACCEL_WORKING2:
> -		*value = rdev->accel_working;
> +		if (rdev->family == CHIP_HAWAII) {
> +			if (rdev->accel_working && rdev->new_fw)
> +				*value = 2;
> +			else
> +				*value = 0;
> +		} else {
> +			*value = rdev->accel_working;
> +		}
>  		break;
>  	case RADEON_INFO_TILING_CONFIG:
>  		if (rdev->family >= CHIP_BONAIRE)
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-07-29 15:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 14:33 [PATCH] drm/radeon: tweak ACCEL_WORKING2 query for hawaii Alex Deucher
2014-07-29 15:39 ` Jerome Glisse [this message]
2014-07-29 17:05   ` Alex Deucher
2014-07-29 17:10     ` Jerome Glisse
2014-07-29 17:22       ` Christian König
2014-07-29 17:31       ` Alex Deucher
2014-07-30  3:26       ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729153913.GA3103@gmail.com \
    --to=j.glisse@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox