From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v5 00/11] Add DRM for stih4xx platforms
Date: Wed, 30 Jul 2014 14:55:23 +0200
Message-ID: <20140730125523.GP4747@phenom.ffwll.local>
References: <CAF6AEGsAtqCjrvrgcXmOY0nie89ppFHBcRPtt36ESHWBNqobTg@mail.gmail.com>
 <CA+M3ks4BU3MTaeCeMPbu8LqW=H27ZAdF-qZLUiG3UXJzbA89Fw@mail.gmail.com>
 <CA+M3ks5osUkkEY64t=M1zEp7DA5rn+MxxqiJhQm5QiEFUPBL+A@mail.gmail.com>
 <CA+M3ks7-ZHghELcRHDiFNbubDZ2DRQPDh2bKKzhsu4EcA0Tzcg@mail.gmail.com>
 <CAF6AEGupwP4aq7EG2SdRUAwy-dzab7fVd2SSoHfGpX8o6yR+WQ@mail.gmail.com>
 <CAPM=9tyKWbffCrUP+3VETEcqAvMG-5+wkW7Rg09BGDnbO=jsBw@mail.gmail.com>
 <CA+M3ks7dfE9nfH6J++fB897PJ407amuxU_g6As-xzPzddTgArw@mail.gmail.com>
 <CAPM=9twxj3KsdqqdeP2S_TyMUDHs5aYHExWC3FyTm=+n153Liw@mail.gmail.com>
 <CA+M3ks5A_aacyDjcAGRPNw1xw82YQJJGwHkZQeY8zvtd6=t1BQ@mail.gmail.com>
 <CA+M3ks5=s33dZ_uz4G+sK+Ckv7CxH11fhDpYG8JAAkHb5kh66Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by gabe.freedesktop.org (Postfix) with ESMTP id 60B746E601
 for <dri-devel@lists.freedesktop.org>; Wed, 30 Jul 2014 05:55:15 -0700 (PDT)
Received: by mail-wg0-f50.google.com with SMTP id n12so1171641wgh.9
 for <dri-devel@lists.freedesktop.org>; Wed, 30 Jul 2014 05:55:14 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+M3ks5=s33dZ_uz4G+sK+Ckv7CxH11fhDpYG8JAAkHb5kh66Q@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>
List-Id: dri-devel@lists.freedesktop.org

On Wed, Jul 30, 2014 at 12:43:33PM +0200, Benjamin Gaignard wrote:
> I have push two additional patches on drm_kms_for_next-v7 branch to
> make the driver build as a module:
> - "gpu: drm: export drm_sysfs_connector_{add,remove} function"

Nope, you're using the wrong functions. Instead you should use
drm_connector_register/unregister. Please don't just export randome
functions without digging into the history a bit.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch