dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: YoungJun Cho <yj44.cho@samsung.com>
Cc: sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org,
	a.hajda@samsung.com, kyungmin.park@samsung.com
Subject: Re: [RFC PATCH] drm/mipi-dsi: add some generic functions for DCS
Date: Tue, 5 Aug 2014 12:08:45 +0200	[thread overview]
Message-ID: <20140805100842.GA10567@ulmo> (raw)
In-Reply-To: <1406780082-9237-1-git-send-email-yj44.cho@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 1616 bytes --]

On Thu, Jul 31, 2014 at 01:14:42PM +0900, YoungJun Cho wrote:
> This patch adds some generic functions for DCS like below
> to standize on common APIs rather than per-driver
> implementations.
> 
> mipi_dcs_enter_sleep_mode() / mipi_dcs_exit_sleep_mode()
> - These are required to disable / enable all blocks inside
>   the display module.
> 
> mipi_dcs_set_display_off() / mipi_dcs_set_display_on()
> - These are required to stop / start displaying the image
>   data on the display device.
> 
> mipi_dcs_set_tear_off() / mipi_dcs_set_tear_on()
> - These are required to turn off or on the display module's
>   TE output signal on the TE signal line.
> 
> mipi_dsi_set_maximum_return_packet_size()
> - Although it is not related with DCS, it is required before
>   using mipi_dsi_dcs_read() to specify the maximum size of
>   the payload in a long packet.
> 
> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
> Acked-by: Inki Dae <inki.dae@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 113 +++++++++++++++++++++++++++++++++++++++++
>  include/drm/drm_mipi_dsi.h     |  14 +++++
>  2 files changed, 127 insertions(+)

I've applied this patch after applying some cleanup and rebasing onto
some changes I've been working on. I also broke it up into two separate
patches, one for the mipi_dsi_set_maximum_return_packet_size() function
and another for the DCS command implementations.

I also have a bunch of other functions that I need for a panel driver
that I'm working on. I'll send those out shortly.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-08-05 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  4:14 [RFC PATCH] drm/mipi-dsi: add some generic functions for DCS YoungJun Cho
2014-08-05 10:08 ` Thierry Reding [this message]
2014-08-07  6:01 ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140805100842.GA10567@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=a.hajda@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kyungmin.park@samsung.com \
    --cc=sw0312.kim@samsung.com \
    --cc=yj44.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox