dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/6] Rename DP training vswing/pre-emph defines
Date: Thu, 7 Aug 2014 11:13:12 +0100	[thread overview]
Message-ID: <20140807101312.GB22241@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1407236902-11326-1-git-send-email-sonika.jindal@intel.com>

On Tue, Aug 05, 2014 at 04:38:16PM +0530, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
> 
> Rename the defines to have levels instead of values for vswing and pre-emph
> levels as the values may differ in other scenarios like low vswing of eDP 1.4
> where the values are different.
> Updated in all the drivers as well

Hi Sonika,

Oops, another mess in this series :) If there's a need to rework the
series and add/remove patches, the best way to send a v2 is to actually
resend the whole series, otherwise someone will get it wrong and won't
apply the right patches.

So, could you resend the whole series again with the patches generated
by Daniel's review comment and with the explanation copy/pasted in all
the driver patches (as Jingoo Han asked). It's fair enough to track why
the rename was needed in driver-specific patches instead of relying on
the cover letter.

Thanks,

-- 
Damien

      parent reply	other threads:[~2014-08-07 10:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 11:08 [PATCH 0/6] Rename DP training vswing/pre-emph defines sonika.jindal
2014-08-05 11:08 ` [PATCH 1/6] drm: Renaming " sonika.jindal
2014-08-05 11:15   ` Daniel Vetter
2014-08-05 11:33     ` Jindal, Sonika
2014-08-05 12:30       ` Daniel Vetter
2014-08-06  5:31         ` Jindal, Sonika
2014-08-06  2:01   ` Jingoo Han
2014-08-05 11:08 ` [PATCH 2/6] drm/i915: " sonika.jindal
2014-08-05 11:08 ` [PATCH 3/6] drm/exynos: " sonika.jindal
2014-08-05 11:08 ` [PATCH 4/6] drm/radeon: " sonika.jindal
2014-08-05 11:08 ` [PATCH 5/6] drm/gma500: " sonika.jindal
2014-08-05 11:08 ` [PATCH 6/6] drm/tegra: " sonika.jindal
2014-08-07 10:13 ` Damien Lespiau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807101312.GB22241@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sonika.jindal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox