From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andrew Jackson <Andrew.Jackson@arm.com>
Subject: Re: [PATCH v3] ASoC: tda998x: add a codec to the HDMI transmitter
Date: Sat, 16 Aug 2014 15:06:16 +0100 [thread overview]
Message-ID: <20140816140616.GN28623@sirena.org.uk> (raw)
In-Reply-To: <20140708114057.5ef3cfd0@armhf>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Tue, Jul 08, 2014 at 11:40:57AM +0200, Jean-Francois Moine wrote:
> .../devicetree/bindings/drm/i2c/tda998x.txt | 13 ++
> drivers/gpu/drm/i2c/Makefile | 2 +-
> drivers/gpu/drm/i2c/tda998x_codec.c | 247 +++++++++++++++++++++
> drivers/gpu/drm/i2c/tda998x_drv.c | 74 ++++--
> drivers/gpu/drm/i2c/tda998x_drv.h | 32 +++
> include/drm/i2c/tda998x.h | 1 +
I'd expect to see the ASoC parts of this appear under sound/soc (even if
just a library that the DRM driver links against rather than as a MFD).
This should help avoid cross tree issues and surprises when people do
API changes.
> + - audio-ports: one or two values corresponding to entries in
> + the audio-port-names property.
What are these values?
> + - audio-port-names: must contain "i2s", "spdif" entries
> + matching entries in the audio-ports property.
So it's mandatory that both I2S and S/PDIF be specified?
The code looks broadly sensible in so far as it
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-16 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 9:40 [PATCH v3] ASoC: tda998x: add a codec to the HDMI transmitter Jean-Francois Moine
2014-07-23 10:22 ` Andrew Jackson
2014-08-16 14:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140816140616.GN28623@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Andrew.Jackson@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox