From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: fix drm_modeset_lock.h kernel-doc notation Date: Mon, 25 Aug 2014 14:57:52 +0200 Message-ID: <20140825125752.GE15520@phenom.ffwll.local> References: <53EFC9F6.7060300@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 349D38996F for ; Mon, 25 Aug 2014 05:57:30 -0700 (PDT) Received: by mail-wg0-f51.google.com with SMTP id b13so12926282wgh.34 for ; Mon, 25 Aug 2014 05:57:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53EFC9F6.7060300@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Randy Dunlap Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org On Sat, Aug 16, 2014 at 02:15:34PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix drm kernel-doc notation to squelch these warnings: > > Warning(..//include/drm/drm_modeset_lock.h:41): cannot understand function prototype: 'struct drm_modeset_acquire_ctx ' > Warning(..//include/drm/drm_modeset_lock.h:66): cannot understand function prototype: 'struct drm_modeset_lock ' > > Need to include the keyword 'struct' for structure descriptions. > > Signed-off-by: Randy Dunlap Reviewed-by: Daniel Vetter And pulled into my drm core stuff topic branch for 3.18 so it won't get lost. -Daniel > --- > include/drm/drm_modeset_lock.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: lnx-317-rc1/include/drm/drm_modeset_lock.h > =================================================================== > --- lnx-317-rc1.orig/include/drm/drm_modeset_lock.h > +++ lnx-317-rc1/include/drm/drm_modeset_lock.h > @@ -29,7 +29,7 @@ > struct drm_modeset_lock; > > /** > - * drm_modeset_acquire_ctx - locking context (see ww_acquire_ctx) > + * struct drm_modeset_acquire_ctx - locking context (see ww_acquire_ctx) > * @ww_ctx: base acquire ctx > * @contended: used internally for -EDEADLK handling > * @locked: list of held locks > @@ -56,7 +56,7 @@ struct drm_modeset_acquire_ctx { > }; > > /** > - * drm_modeset_lock - used for locking modeset resources. > + * struct drm_modeset_lock - used for locking modeset resources. > * @mutex: resource locking > * @head: used to hold it's place on state->locked list when > * part of an atomic update > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch