From: Dan Carpenter <dan.carpenter@oracle.com>
To: benjamin.gaignard@linaro.org
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm: sti: add HDMI driver
Date: Fri, 29 Aug 2014 11:15:51 +0300 [thread overview]
Message-ID: <20140829081551.GA14412@mwanda> (raw)
Hello Benjamin Gaignard,
The patch 5402626c83a2: "drm: sti: add HDMI driver" from Jul 30,
2014, leads to the following static checker warning:
drivers/gpu/drm/sti/sti_hdmi.c:301 hdmi_avi_infoframe_config()
error: buffer overflow 'frame' 13 <= 13
drivers/gpu/drm/sti/sti_hdmi.c
298 hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD2(HDMI_IFRAME_SLOT_AVI));
299
300 val = frame[0xC];
301 val |= frame[0xD] << 8;
frame[] only has 0xD elements so we are one element past the end here.
302 hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD3(HDMI_IFRAME_SLOT_AVI));
303
regards,
dan carpenter
reply other threads:[~2014-08-29 8:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829081551.GA14412@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox