From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 06/20] drm: move AGP definitions harder Date: Fri, 29 Aug 2014 14:39:10 +0200 Message-ID: <20140829123910.GD15520@phenom.ffwll.local> References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com> <1409307166-12396-7-git-send-email-dh.herrmann@gmail.com> <20140829114308.GF17519@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FEFA6E3D5 for ; Fri, 29 Aug 2014 05:38:49 -0700 (PDT) Received: by mail-we0-f175.google.com with SMTP id k48so2133583wev.20 for ; Fri, 29 Aug 2014 05:38:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140829114308.GF17519@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Aug 29, 2014 at 01:43:10PM +0200, Thierry Reding wrote: > On Fri, Aug 29, 2014 at 12:12:32PM +0200, David Herrmann wrote: > > Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. > > Unfortunately, drivers still heavily access drm_agp_head so we cannot > > move it to drm_legacy.h. However, at least it's no longer visible in > > drmP.h now (it's directly included from it, though). > > > > Signed-off-by: David Herrmann > > --- > > drivers/gpu/drm/drm_agpsupport.c | 1 + > > drivers/gpu/drm/drm_legacy.h | 15 +++++++++++++++ > > drivers/gpu/drm/drm_memory.c | 1 + > > drivers/gpu/drm/drm_vm.c | 1 + > > include/drm/drmP.h | 30 +----------------------------- > > include/drm/drm_agpsupport.h | 13 +++++++++++++ > > 6 files changed, 32 insertions(+), 29 deletions(-) > > I don't know exactly what you mean by "move harder" in the subject, but > other than that this looks good, so with a better subject this is: I guess "Try to hide AGP definitions harder" would be more accurate. -Daniel > > Reviewed-by: Thierry Reding -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch