From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH -v2 1/4] drm/i915: init sprites with
 univeral plane init function
Date: Wed, 3 Sep 2014 10:36:16 +0200
Message-ID: <20140903083616.GE15520@phenom.ffwll.local>
References: <1409685827-29067-1-git-send-email-gustavo@padovan.org>
 <20140903081827.GP4193@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20140903081827.GP4193@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Derek Foreman <derek.foreman@collabora.co.uk>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, Sep 03, 2014 at 11:18:27AM +0300, Ville Syrj=E4l=E4 wrote:
> On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote:
> > From: Derek Foreman <derek.foreman@collabora.co.uk>
> > =

> > Really just for completeness - old init function ends up making the pla=
ne
> > exactly the same way due to the way the enums are set up.
> > =

> > Signed-off-by: Derek Foreman <derek.foreman@collabora.co.uk>
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
> =

> > ---
> >  drivers/gpu/drm/i915/intel_sprite.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > =

> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915=
/intel_sprite.c
> > index 0bdb00b..4cbe286 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -1375,10 +1375,10 @@ intel_plane_init(struct drm_device *dev, enum p=
ipe pipe, int plane)
> >  	intel_plane->plane =3D plane;
> >  	intel_plane->rotation =3D BIT(DRM_ROTATE_0);
> >  	possible_crtcs =3D (1 << pipe);
> > -	ret =3D drm_plane_init(dev, &intel_plane->base, possible_crtcs,
> > -			     &intel_plane_funcs,
> > -			     plane_formats, num_plane_formats,
> > -			     false);
> > +	ret =3D drm_universal_plane_init(dev, &intel_plane->base, possible_cr=
tcs,
> > +				       &intel_plane_funcs,
> > +				       plane_formats, num_plane_formats,
> > +				       DRM_PLANE_TYPE_OVERLAY);
> >  	if (ret) {
> >  		kfree(intel_plane);
> >  		goto out;
> > -- =

> > 1.9.3
> > =

> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> =

> -- =

> Ville Syrj=E4l=E4
> Intel OTC
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch