From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerome Glisse <j.glisse@gmail.com>
Subject: Re: [PATCH 1/8] drm/<ttm-based-drivers>: Don't call drm_mmap
Date: Tue, 23 Sep 2014 17:57:56 -0400
Message-ID: <20140923215756.GB13669@gmail.com>
References: <1411480014-10138-1-git-send-email-daniel.vetter@ffwll.ch>
 <1411480014-10138-2-git-send-email-daniel.vetter@ffwll.ch>
 <20140923213813.GA13669@gmail.com>
 <CANq1E4ThgF+oChBy8Y_oAnnzq0X=jdPFRJobZUGBuTcC9iDFVQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-qa0-f41.google.com (mail-qa0-f41.google.com
 [209.85.216.41])
 by gabe.freedesktop.org (Postfix) with ESMTP id 12B376E5B0
 for <dri-devel@lists.freedesktop.org>; Tue, 23 Sep 2014 14:58:00 -0700 (PDT)
Received: by mail-qa0-f41.google.com with SMTP id cm18so2379220qab.28
 for <dri-devel@lists.freedesktop.org>; Tue, 23 Sep 2014 14:57:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CANq1E4ThgF+oChBy8Y_oAnnzq0X=jdPFRJobZUGBuTcC9iDFVQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Christian Engelmayer <cengelma@gmx.at>, Daniel Vetter <daniel.vetter@ffwll.ch>, Josh Triplett <josh@joshtriplett.org>, DRI Development <dri-devel@lists.freedesktop.org>, Fabian Frederick <fabf@skynet.be>, Rashika <rashika.kheria@gmail.com>, Ben Skeggs <bskeggs@redhat.com>, Alex Deucher <alexander.deucher@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
List-Id: dri-devel@lists.freedesktop.org

On Tue, Sep 23, 2014 at 11:53:53PM +0200, David Herrmann wrote:
> Hi
> =

> On Tue, Sep 23, 2014 at 11:38 PM, Jerome Glisse <j.glisse@gmail.com> wrot=
e:
> > On Tue, Sep 23, 2014 at 03:46:47PM +0200, Daniel Vetter wrote:
> >> Really, the legacy buffer api should be dead, especially for all these
> >> newfangled drivers. I suspect this is copypasta from the transitioning
> >> days, which probably originated in radeon.
> >>
> >> Cc: David Airlie <airlied@linux.ie>
> >> Cc: Alex Deucher <alexander.deucher@amd.com>
> >> Cc: "Christian K=F6nig" <christian.koenig@amd.com>
> >> Cc: David Herrmann <dh.herrmann@gmail.com>
> >> Cc: Rashika <rashika.kheria@gmail.com>
> >> Cc: Josh Triplett <josh@joshtriplett.org>
> >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> >> Cc: Fabian Frederick <fabf@skynet.be>
> >> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >> Cc: Ben Skeggs <bskeggs@redhat.com>
> >> Cc: Alexandre Courbot <acourbot@nvidia.com>
> >> Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> >> Cc: Christian Engelmayer <cengelma@gmx.at>
> >> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >
> > I would say NAK as i am pretty sure this break radeon UMS code path.
> > Of course if we have the go ahead to nuke radeon UMS i am more than
> > happy.
> =

> radeon_drv.c says:
>         driver_old.fops.mmap =3D=3D drm_mmap;
> =

> ..so I don't understand why that would break UMS? Do you use KMS mixed
> with UMS? radeon_mmap() is only used by radeon_driver_kms_fops, which
> is only used by kms_driver. UMS (which I understand as non-KMS in
> radeon case) should not be affected by this.

Oh this might be an heritage of old code in my mind when we had old user
space running on top of KMS, more as a prototype stage and maybe also at
one point the plan was to share the same mmap function so that old code
could use new code cs ioctl.

So yeah this can be nuke sorry for the noise.
> =

> Thanks
> David