From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/crtc: Remove duplicated ioctl code Date: Wed, 22 Oct 2014 10:39:29 +0200 Message-ID: <20141022083929.GM26941@phenom.ffwll.local> References: <20141008114034.2e1ab40d@as> <20141021140810.GL4284@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id D99D46E28C for ; Wed, 22 Oct 2014 01:39:20 -0700 (PDT) Received: by mail-wi0-f175.google.com with SMTP id d1so673054wiv.2 for ; Wed, 22 Oct 2014 01:39:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20141021140810.GL4284@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Chuck Ebbert , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Tue, Oct 21, 2014 at 05:08:10PM +0300, Ville Syrj=E4l=E4 wrote: > On Wed, Oct 08, 2014 at 11:40:34AM -0500, Chuck Ebbert wrote: > > Make drm_mode_add_fb() call drm_mode_add_fb2() after converting its > > args to the new internal format, instead of duplicating code. > > = > > Also picks up a lot more error checking, which the legacy modes > > should pass after being converted to the new format. > > = > > Signed-off-by: Chuck Ebbert > = > Looks good to me. > = > Reviewed-by: Ville Syrj=E4l=E4 Picked up into my drm core stuff queue. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch