From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/6] drm: add tile_group support. Date: Wed, 22 Oct 2014 10:42:23 +0200 Message-ID: <20141022084223.GN26941@phenom.ffwll.local> References: <1413787036-19114-1-git-send-email-airlied@gmail.com> <1413787036-19114-3-git-send-email-airlied@gmail.com> <20141020153223.GO26941@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Airlie Cc: "intel-gfx@lists.freedesktop.org" , dri-devel List-Id: dri-devel@lists.freedesktop.org On Wed, Oct 22, 2014 at 12:23:30PM +1000, Dave Airlie wrote: > > And kerneldoc for the non-exported functions please, preferrably with some > > overview DOC: section to pull it all together. > > I'm posting v2, advice on kerneldoc required, so the functions end up > in the right place, I don't really wnat to add a new C file for this. Argh sorry that was a boilerplate reply that escated ;-) I've sent the same one to pretty much all the recent i915 patch series where this is the new rule. I don't think drm internal docs make a lot of sense as long as all the driver stuff is nicely documented. Some barrier to entry for core drm might actually be useful ... Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch