From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: Modesetting lock changes breaks vmwgfx since 3.18-rc1
Date: Fri, 31 Oct 2014 18:33:21 +0100 [thread overview]
Message-ID: <20141031173321.GX26941@phenom.ffwll.local> (raw)
In-Reply-To: <54524E1B.4010701@vmware.com>
On Thu, Oct 30, 2014 at 03:41:31PM +0100, Thomas Hellstrom wrote:
> Hi!
>
> Details in
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1155825
>
> Can whoever broke the driver please make an effort to fix it up?
>
> Daniel, You've been named as a suspect. I'm not sure if that is true.
Yeah the recent locking frobbing didn't account for the FIXME comment in
vmwgfx. Might be good to address that long-term to get vmwgfx more in line
with everyone else again - I simply don't understand the interactions well
enough to make that call. There's two of those in total.
Can we just remove them perhaps? The question is whether you can do the
cursor operation just with the per-crtc lock as protection, or whether
there's any shared resources and you need the full exclusion provided by
modeset_lock_all. If the crtc locking is good enough then we could rip
this out in both function and be done.
Note that this FIXME has been in vmwgfx since almost two years now.
If that's not possible then I have a major kludge of a hack in my atomic
helpers branch which will keep this alive for a bit longer. It ain't
pretty though.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-10-31 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 14:41 Modesetting lock changes breaks vmwgfx since 3.18-rc1 Thomas Hellstrom
2014-10-31 17:33 ` Daniel Vetter [this message]
2014-11-03 10:29 ` Thomas Hellstrom
2014-11-03 16:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031173321.GX26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox