From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/vmwgfx: fix lock breakage Date: Fri, 31 Oct 2014 18:35:49 +0100 Message-ID: <20141031173549.GY26941@phenom.ffwll.local> References: <1414690744-8750-1-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 740BE6E5F0 for ; Fri, 31 Oct 2014 10:35:36 -0700 (PDT) Received: by mail-wg0-f42.google.com with SMTP id k14so8439649wgh.1 for ; Fri, 31 Oct 2014 10:35:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1414690744-8750-1-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: Thomas Hellstrom , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMzAsIDIwMTQgYXQgMDE6Mzk6MDRQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IEFmdGVyOgo+IAo+IGNvbW1pdCBkMDU5ZjY1MmU3M2MzNTY3OGQyOGQ0Y2QwOWFiMmNlYzg5 Njk2YWY5Cj4gQXV0aG9yOiAgICAgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4KPiBBdXRob3JEYXRlOiBGcmkgSnVsIDI1IDE4OjA3OjQwIDIwMTQgKzAyMDAKPiAKPiAgICAg ZHJtOiBIYW5kbGUgbGVnYWN5IHBlci1jcnRjIGxvY2tpbmcgd2l0aCBmdWxsIGFjcXVpcmUgY3R4 Cj4gCj4gZHJtX21vZGVfY3Vyc29yX2NvbW1vbigpIHdhcyBzd2l0Y2hlZCB0byB1c2UgZHJtX21v ZGVzZXRfKHVuKWxvY2tfY3J0YygpCj4gd2hpY2ggdXNlcyBmdWxsIGFxdWlyZSBjdHguICBTbyBk cm9wcGluZy9yZWFxdWlyaW5nIHRoZSBsb2NrIHZpYQo+IGRybV9tb2Rlc2V0Xyh1bilsb2NrKCkg ZGlyZWN0bHkgaXNuJ3QgdGhlIHJpZ2h0IHRoaW5nIHRvIGRvLCBhcyBsb2NrZGVwCj4ga2luZGx5 IHBvaW50cyBvdXQuCj4gCj4gVGhlICdGSVhNRSdzIGFib3V0IHNvcnRpbmcgb3V0IHdoZXRoZXIg dm13Z2Z4ICpyZWFsbHkqIG5lZWRzIHRvIGxvY2stYWxsCj4gZm9yIGN1cnNvciB1cGRhdGVzIHN0 aWxsIGFwcGx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWls LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMgfCA4ICsr KystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5jIGIv ZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMKPiBpbmRleCBkMmJjMmIwLi44ZmMx ZTM4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMKPiBAQCAtMTg3LDcgKzE4 Nyw3IEBAIGludCB2bXdfZHVfY3J0Y19jdXJzb3Jfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0Yywg c3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYsCj4gIAkgKiBjYW4gZG8gdGhpcyBzaW5jZSB0aGUg Y2FsbGVyIGluIHRoZSBkcm0gY29yZSBkb2Vzbid0IGNoZWNrIGFueXRoaW5nCj4gIAkgKiB3aGlj aCBpcyBwcm90ZWN0ZWQgYnkgYW55IGxvb2tzLgo+ICAJICovCj4gLQlkcm1fbW9kZXNldF91bmxv Y2soJmNydGMtPm11dGV4KTsKPiArCWRybV9tb2Rlc2V0X3VubG9ja19jcnRjKGNydGMpOwo+ICAJ ZHJtX21vZGVzZXRfbG9ja19hbGwoZGV2X3ByaXYtPmRldik7CgpPaCByaWdodCB0aGlzIGlzIHNp bXBsZXIsIGJ1dCBpdCBhbHNvIGdyYWJzIGEgbmV3IGFjcXVpcmUgY29udGV4dC4gU28gbm90CnRv byB0ZXJyaWJseSBmYWlyIHJlYWxseSwgYnV0IG90b2ggbmVpdGhlciB3YXMgdGhlIG9sZCBvbmUu CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAg Cj4gIAkvKiBBIGxvdCBvZiB0aGUgY29kZSBhc3N1bWVzIHRoaXMgKi8KPiBAQCAtMjUyLDcgKzI1 Miw3IEBAIGludCB2bXdfZHVfY3J0Y19jdXJzb3Jfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0Yywg c3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYsCj4gIAlyZXQgPSAwOwo+ICBvdXQ6Cj4gIAlkcm1f bW9kZXNldF91bmxvY2tfYWxsKGRldl9wcml2LT5kZXYpOwo+IC0JZHJtX21vZGVzZXRfbG9jaygm Y3J0Yy0+bXV0ZXgsIE5VTEwpOwo+ICsJZHJtX21vZGVzZXRfbG9ja19jcnRjKGNydGMpOwo+ICAK PiAgCXJldHVybiByZXQ7Cj4gIH0KPiBAQCAtMjczLDcgKzI3Myw3IEBAIGludCB2bXdfZHVfY3J0 Y19jdXJzb3JfbW92ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIGludCB4LCBpbnQgeSkKPiAgCSAq IGNhbiBkbyB0aGlzIHNpbmNlIHRoZSBjYWxsZXIgaW4gdGhlIGRybSBjb3JlIGRvZXNuJ3QgY2hl Y2sgYW55dGhpbmcKPiAgCSAqIHdoaWNoIGlzIHByb3RlY3RlZCBieSBhbnkgbG9va3MuCj4gIAkg Ki8KPiAtCWRybV9tb2Rlc2V0X3VubG9jaygmY3J0Yy0+bXV0ZXgpOwo+ICsJZHJtX21vZGVzZXRf dW5sb2NrX2NydGMoY3J0Yyk7Cj4gIAlkcm1fbW9kZXNldF9sb2NrX2FsbChkZXZfcHJpdi0+ZGV2 KTsKPiAgCj4gIAl2bXdfY3Vyc29yX3VwZGF0ZV9wb3NpdGlvbihkZXZfcHJpdiwgc2hvd24sCj4g QEAgLTI4MSw3ICsyODEsNyBAQCBpbnQgdm13X2R1X2NydGNfY3Vyc29yX21vdmUoc3RydWN0IGRy bV9jcnRjICpjcnRjLCBpbnQgeCwgaW50IHkpCj4gIAkJCQkgICBkdS0+Y3Vyc29yX3kgKyBkdS0+ aG90c3BvdF95KTsKPiAgCj4gIAlkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRldl9wcml2LT5kZXYp Owo+IC0JZHJtX21vZGVzZXRfbG9jaygmY3J0Yy0+bXV0ZXgsIE5VTEwpOwo+ICsJZHJtX21vZGVz ZXRfbG9ja19jcnRjKGNydGMpOwo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4gLS0gCj4gMS45LjMK PiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==