From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/7] drm/cma: Introduce drm_gem_cma_dumb_create_internal() Date: Wed, 5 Nov 2014 15:36:58 +0100 Message-ID: <20141105143658.GP26941@phenom.ffwll.local> References: <1415193919-1687-1-git-send-email-thierry.reding@gmail.com> <1415193919-1687-5-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 576536E925 for ; Wed, 5 Nov 2014 06:36:45 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id d1so12593956wiv.7 for ; Wed, 05 Nov 2014 06:36:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <1415193919-1687-5-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Benjamin Gaignard , Daniel Vetter , dri-devel@lists.freedesktop.org, Tomi Valkeinen , Archit Taneja , Laurent Pinchart , Russell King , Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMDUsIDIwMTQgYXQgMDI6MjU6MTZQTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBU aGlzIGZ1bmN0aW9uIGlzIHNpbWlsYXIgdG8gZHJtX2dlbV9jbWFfZHVtYl9jcmVhdGUoKSBidXQg dGFyZ2V0dGVkIGF0Cj4ga2VybmVsIGludGVybmFsIHVzZXJzIHNvIHRoYXQgdGhleSBjYW4gb3Zl cnJpZGUgdGhlIHBpdGNoIGFuZCBzaXplCj4gcmVxdWlyZW1lbnRzIG9mIHRoZSBkdW1iIGJ1ZmZl ci4KPiAKPiBJdCBpcyBpbXBvcnRhbnQgdG8gbWFrZSB0aGlzIGRpZmZlcmVuY2UgYmVjYXVzZSB0 aGUgSU9DVEwgc2F5cyB0aGF0IHRoZQo+IHBpdGNoIGFuZCBzaXplIGZpZWxkcyBhcmUgdG8gYmUg Y29uc2lkZXJlZCBvdXRwdXRzIGFuZCB0aGVyZWZvcmUgc2hvdWxkCj4gbm90IGJlIHVzZWQgaW4g Y29tcHV0YXRpb25zIG9mIHRoZSBmcmFtZWJ1ZmZlciBzaXplLiBJbnRlcm5hbCB1c2VycyBtYXkK PiBzdGlsbCB3YW50IHRvIHVzZSB0aGlzIGNvZGUgdG8gYXZvaWQgZHVwbGljYXRpb24gYW5kIGF0 IHRoZSBzYW1lIHRpbWUKPiBwYXNzIG9uIGFkZGl0aW9uYWwsIGRyaXZlci1zcGVjaWZpYyByZXN0 cmljdGlvbnMgb24gdGhlIHBpdGNoIGFuZCBzaXplLgo+IAo+IFdoaWxlIGF0IGl0LCBjb252ZXJ0 IHRoZSBSLUNhciBEVSBkcml2ZXIsIHRoZSBzaW5nbGUgdXNlciB0aGF0IG92ZXJyaWRlcwo+IHRo ZSBwaXRjaCwgdG8gdXNlIHRoZSBuZXcgaW50ZXJuYWwgaGVscGVyLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+CgpTb21lIGNvbW1lbnRzIGFi b3V0IHRoZSBrZXJuZWxkb2MsIHdpdGggdGhhdCBhZGRyZXNzIChuZWVkcyB0aGUgYWxpZ25tZW50 CndpdGggdGhlIHByZXZpb3VzIHBhdGNoIGVzc2VudGlhbGx5KSB0aGlzIGlzCgpSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fZ2VtX2NtYV9oZWxwZXIuYyAgfCAzMyArKysrKysrKysrKysrKysrKysr KysrKysrKysrLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYyB8 ICAyICstCj4gIGluY2x1ZGUvZHJtL2RybV9nZW1fY21hX2hlbHBlci5oICAgICAgfCAgNSArKysr Kwo+ICAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2NtYV9oZWxwZXIuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2NtYV9oZWxwZXIuYwo+IGluZGV4IDU1MzA2YmUxZjhmNy4u YzU1OTg2NTY2ZjBjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2NtYV9o ZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2NtYV9oZWxwZXIuYwo+IEBA IC0xODksNyArMTg5LDcgQEAgdm9pZCBkcm1fZ2VtX2NtYV9mcmVlX29iamVjdChzdHJ1Y3QgZHJt X2dlbV9vYmplY3QgKmdlbV9vYmopCj4gIEVYUE9SVF9TWU1CT0xfR1BMKGRybV9nZW1fY21hX2Zy ZWVfb2JqZWN0KTsKPiAgCj4gIC8qKgo+IC0gKiBkcm1fZ2VtX2NtYV9kdW1iX2NyZWF0ZSAtIGNy ZWF0ZSBhIGR1bWIgYnVmZmVyIG9iamVjdAo+ICsgKiBkcm1fZ2VtX2NtYV9kdW1iX2NyZWF0ZV9p bnRlcm5hbCAtIGNyZWF0ZSBhIGR1bWIgYnVmZmVyIG9iamVjdAo+ICAgKiBAZmlsZV9wcml2OiBE Uk0gZmlsZS1wcml2YXRlIHN0cnVjdHVyZSB0byBjcmVhdGUgdGhlIGR1bWIgYnVmZmVyIGZvcgo+ ICAgKiBAZHJtOiBEUk0gZGV2aWNlCj4gICAqIEBhcmdzOiBJT0NUTCBkYXRhCj4gQEAgLTE5OSwx MiArMTk5LDEyIEBAIEVYUE9SVF9TWU1CT0xfR1BMKGRybV9nZW1fY21hX2ZyZWVfb2JqZWN0KTsK Cktlcm5lbGRvYyBzaG91bGQgYmUgdXBkYXRlIHRvIG1lbnRpb24gd2hhdCBleGFjdGx5IHRoaXMg aXMgdXNlZnVsIGZvciwgYW5kCmhvdyBpdCBkaWZmZXJzIGZyb20gdGhlIGRybV9nZW1fY21hX2R1 bWJfY3JlYXRlKCkuCj4gICAqCj4gICAqIFJldHVybjogMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRp dmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICAgKi8KPiAtaW50IGRybV9nZW1fY21hX2R1bWJf Y3JlYXRlKHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LAo+IC0JCQkgICAgc3RydWN0IGRybV9k ZXZpY2UgKmRybSwKPiAtCQkJICAgIHN0cnVjdCBkcm1fbW9kZV9jcmVhdGVfZHVtYiAqYXJncykK PiAraW50IGRybV9nZW1fY21hX2R1bWJfY3JlYXRlX2ludGVybmFsKHN0cnVjdCBkcm1fZmlsZSAq ZmlsZV9wcml2LAo+ICsJCQkJICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLAo+ICsJCQkJICAg ICBzdHJ1Y3QgZHJtX21vZGVfY3JlYXRlX2R1bWIgKmFyZ3MpCj4gIHsKPiArCXVuc2lnbmVkIGlu dCBtaW5fcGl0Y2ggPSBESVZfUk9VTkRfVVAoYXJncy0+d2lkdGggKiBhcmdzLT5icHAsIDgpOwo+ ICAJc3RydWN0IGRybV9nZW1fY21hX29iamVjdCAqY21hX29iajsKPiAtCWludCBtaW5fcGl0Y2gg PSBESVZfUk9VTkRfVVAoYXJncy0+d2lkdGggKiBhcmdzLT5icHAsIDgpOwo+ICAKPiAgCWlmIChh cmdzLT5waXRjaCA8IG1pbl9waXRjaCkKPiAgCQlhcmdzLT5waXRjaCA9IG1pbl9waXRjaDsKPiBA QCAtMjE2LDYgKzIxNiwyOSBAQCBpbnQgZHJtX2dlbV9jbWFfZHVtYl9jcmVhdGUoc3RydWN0IGRy bV9maWxlICpmaWxlX3ByaXYsCj4gIAkJCQkJCSAmYXJncy0+aGFuZGxlKTsKPiAgCXJldHVybiBQ VFJfRVJSX09SX1pFUk8oY21hX29iaik7Cj4gIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwoZHJtX2dl bV9jbWFfZHVtYl9jcmVhdGVfaW50ZXJuYWwpOwo+ICsKPiArLyoqCj4gKyAqIGRybV9nZW1fY21h X2R1bWJfY3JlYXRlIC0gY3JlYXRlIGEgZHVtYiBidWZmZXIgb2JqZWN0Cj4gKyAqIEBmaWxlX3By aXY6IERSTSBmaWxlLXByaXZhdGUgc3RydWN0dXJlIHRvIGNyZWF0ZSB0aGUgZHVtYiBidWZmZXIg Zm9yCj4gKyAqIEBkcm06IERSTSBkZXZpY2UKPiArICogQGFyZ3M6IElPQ1RMIGRhdGEKClNhbWUg aGVyZSAoYW5kIHJhaXNlZCBpbiB0aGUgcHJldmlvdXMga2VybmVsZG9jIHBhdGNoIGFscmVhZHkp LCB0aGlzIG5lZWRzCnNvbWUgY29tbWVudHMgb24gd2hhdCBpdCdzIHVzZWZ1bCBmb3IgYW5kIHdo YXQncyB0aGUgZGlmZmVyZW5jZSB3aXRoIHRoZQpfaW50ZXJuYWwgdmFyaWFudC4KCj4gKyAqCj4g KyAqIFJldHVybjogMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRpdmUgZXJyb3IgY29kZSBvbiBmYWls dXJlLgo+ICsgKi8KPiAraW50IGRybV9nZW1fY21hX2R1bWJfY3JlYXRlKHN0cnVjdCBkcm1fZmls ZSAqZmlsZV9wcml2LAo+ICsJCQkgICAgc3RydWN0IGRybV9kZXZpY2UgKmRybSwKPiArCQkJICAg IHN0cnVjdCBkcm1fbW9kZV9jcmVhdGVfZHVtYiAqYXJncykKPiArewo+ICsJc3RydWN0IGRybV9n ZW1fY21hX29iamVjdCAqY21hX29iajsKPiArCj4gKwlhcmdzLT5waXRjaCA9IERJVl9ST1VORF9V UChhcmdzLT53aWR0aCAqIGFyZ3MtPmJwcCwgOCk7Cj4gKwlhcmdzLT5zaXplID0gYXJncy0+cGl0 Y2ggKiBhcmdzLT5oZWlnaHQ7Cj4gKwo+ICsJY21hX29iaiA9IGRybV9nZW1fY21hX2NyZWF0ZV93 aXRoX2hhbmRsZShmaWxlX3ByaXYsIGRybSwgYXJncy0+c2l6ZSwKPiArCQkJCQkJICZhcmdzLT5o YW5kbGUpOwo+ICsJcmV0dXJuIFBUUl9FUlJfT1JfWkVSTyhjbWFfb2JqKTsKPiArfQo+ICBFWFBP UlRfU1lNQk9MX0dQTChkcm1fZ2VtX2NtYV9kdW1iX2NyZWF0ZSk7Cj4gIAo+ICAvKioKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYyBiL2RyaXZlcnMv Z3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfa21zLmMKPiBpbmRleCA2YzI0YWQ3ZDAzZWYuLjUzMjk0 OTFlMzJjMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2tt cy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYwo+IEBAIC0x MjgsNyArMTI4LDcgQEAgaW50IHJjYXJfZHVfZHVtYl9jcmVhdGUoc3RydWN0IGRybV9maWxlICpm aWxlLCBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAKPiAgCWFyZ3MtPnBpdGNoID0gcm91bmR1 cChtYXgoYXJncy0+cGl0Y2gsIG1pbl9waXRjaCksIGFsaWduKTsKPiAgCj4gLQlyZXR1cm4gZHJt X2dlbV9jbWFfZHVtYl9jcmVhdGUoZmlsZSwgZGV2LCBhcmdzKTsKPiArCXJldHVybiBkcm1fZ2Vt X2NtYV9kdW1iX2NyZWF0ZV9pbnRlcm5hbChmaWxlLCBkZXYsIGFyZ3MpOwo+ICB9Cj4gIAo+ICBz dGF0aWMgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt L2RybV9nZW1fY21hX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2dlbV9jbWFfaGVscGVyLmgK PiBpbmRleCA4NzNkNGViN2YxMjUuLmFjZDZhZjhhOGU2NyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRl L2RybS9kcm1fZ2VtX2NtYV9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9nZW1fY21h X2hlbHBlci5oCj4gQEAgLTMwLDYgKzMwLDExIEBAIHRvX2RybV9nZW1fY21hX29iaihzdHJ1Y3Qg ZHJtX2dlbV9vYmplY3QgKmdlbV9vYmopCj4gIHZvaWQgZHJtX2dlbV9jbWFfZnJlZV9vYmplY3Qo c3RydWN0IGRybV9nZW1fb2JqZWN0ICpnZW1fb2JqKTsKPiAgCj4gIC8qIGNyZWF0ZSBtZW1vcnkg cmVnaW9uIGZvciBEUk0gZnJhbWVidWZmZXIgKi8KPiAraW50IGRybV9nZW1fY21hX2R1bWJfY3Jl YXRlX2ludGVybmFsKHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LAo+ICsJCQkJICAgICBzdHJ1 Y3QgZHJtX2RldmljZSAqZHJtLAo+ICsJCQkJICAgICBzdHJ1Y3QgZHJtX21vZGVfY3JlYXRlX2R1 bWIgKmFyZ3MpOwo+ICsKPiArLyogY3JlYXRlIG1lbW9yeSByZWdpb24gZm9yIERSTSBmcmFtZWJ1 ZmZlciAqLwo+ICBpbnQgZHJtX2dlbV9jbWFfZHVtYl9jcmVhdGUoc3RydWN0IGRybV9maWxlICpm aWxlX3ByaXYsCj4gIAkJCSAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLAo+ICAJCQkgICAgc3Ry dWN0IGRybV9tb2RlX2NyZWF0ZV9kdW1iICphcmdzKTsKPiAtLSAKPiAyLjEuMwo+IAoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkg NzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK