From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 1/3] drm/tegra: Fix error handling cleanup Date: Thu, 6 Nov 2014 13:56:16 -0500 Message-ID: <20141106185616.GA36383@philcollins> References: <1415289436-14797-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qg0-f48.google.com (mail-qg0-f48.google.com [209.85.192.48]) by gabe.freedesktop.org (Postfix) with ESMTP id D96E76E88A for ; Thu, 6 Nov 2014 10:56:45 -0800 (PST) Received: by mail-qg0-f48.google.com with SMTP id q108so1239717qgd.21 for ; Thu, 06 Nov 2014 10:56:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <1415289436-14797-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: =?iso-8859-1?Q?St=E9phane?= Marchesin , Sean Paul , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDYsIDIwMTQgYXQgMDQ6NTc6MTRQTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBU aGUgRFJNIGRyaXZlcidzIC0+bG9hZCgpIGltcGxlbWVudGF0aW9uIGRpZG4ndCBkbyBhIGdvb2Qg am9iIChubyBqb2IgYXQKPiBhbGwgcmVhbGx5KSBjbGVhbmluZyB1cCBvbiBmYWlsdXJlLiBGaXgg dGhhdCBieSB1bmRvaW5nIGFueSBwcmlvciBzZXR1cAo+IHdoZW4gYW4gZXJyb3Igb2NjdXJzLiBU aGlzIHJlcXVpcmVzIGEgYml0IG9mIHJld29yayB0byBtYWtlIGl0IHBvc3NpYmxlCj4gdG8gY2xl YW4gdXAgZmJkZXYgbWlkd2F5Lgo+IAo+IFRoaXMgd2FzIHRlc3RlZCBieSBpbmplY3RpbmcgZXJy b3JzIGF0IHZhcmlvdXMgcG9pbnRzIGR1cmluZyB0aGUKPiBpbml0aWFsaXphdGlvbiBzZXF1ZW5j ZSBhbmQgdmVyaWZ5aW5nIHRoYXQgZXJyb3IgY2xlYW51cCBkaWRuJ3QgY3Jhc2gKPiBhbmQgbm8g bWVtb3J5IGxlYWtlZCAodXNpbmcga21lbWxlYWspLgo+IAo+IFJlcG9ydGVkLWJ5OiBTdMOpcGhh bmUgTWFyY2hlc2luIDxtYXJjaGV1QGdvb2dsZS5jb20+Cj4gUmVwb3J0ZWQtYnk6IFNlYW4gUGF1 bCA8c2VhbnBhdWxAZ29vZ2xlLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBUaGllcnJ5IFJlZGluZyA8 dHJlZGluZ0BudmlkaWEuY29tPgoKTG9va3MgbXVjaCBiZXR0ZXIgOi0pCgpSZXZpZXdlZC1ieTog U2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vdGVncmEvZHJtLmMgfCAyMCArKysrKysrKysrKysrKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vdGVncmEvZHJtLmggfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS90ZWdyYS9mYi5jICB8IDIw ICsrKysrKysrKysrKysrKysrLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3RlZ3Jh L2RybS5jIGIvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RybS5jCj4gaW5kZXggNTk3MzZiYjgxMGNk Li5lMTYzMmZiMDNhODkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RybS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RybS5jCj4gQEAgLTQyLDEzICs0MiwxMyBA QCBzdGF0aWMgaW50IHRlZ3JhX2RybV9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0sIHVuc2ln bmVkIGxvbmcgZmxhZ3MpCj4gIAo+ICAJZXJyID0gdGVncmFfZHJtX2ZiX3ByZXBhcmUoZHJtKTsK PiAgCWlmIChlcnIgPCAwKQo+IC0JCXJldHVybiBlcnI7Cj4gKwkJZ290byBjb25maWc7Cj4gIAo+ ICAJZHJtX2ttc19oZWxwZXJfcG9sbF9pbml0KGRybSk7Cj4gIAo+ICAJZXJyID0gaG9zdDF4X2Rl dmljZV9pbml0KGRldmljZSk7Cj4gIAlpZiAoZXJyIDwgMCkKPiAtCQlyZXR1cm4gZXJyOwo+ICsJ CWdvdG8gZmJkZXY7Cj4gIAo+ICAJLyoKPiAgCSAqIFdlIGRvbid0IHVzZSB0aGUgZHJtX2lycV9p bnN0YWxsKCkgaGVscGVycyBwcm92aWRlZCBieSB0aGUgRFJNCj4gQEAgLTU5LDEzICs1OSwyNSBA QCBzdGF0aWMgaW50IHRlZ3JhX2RybV9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0sIHVuc2ln bmVkIGxvbmcgZmxhZ3MpCj4gIAo+ICAJZXJyID0gZHJtX3ZibGFua19pbml0KGRybSwgZHJtLT5t b2RlX2NvbmZpZy5udW1fY3J0Yyk7Cj4gIAlpZiAoZXJyIDwgMCkKPiAtCQlyZXR1cm4gZXJyOwo+ ICsJCWdvdG8gZGV2aWNlOwo+ICAKPiAgCWVyciA9IHRlZ3JhX2RybV9mYl9pbml0KGRybSk7Cj4g IAlpZiAoZXJyIDwgMCkKPiAtCQlyZXR1cm4gZXJyOwo+ICsJCWdvdG8gdmJsYW5rOwo+ICAKPiAg CXJldHVybiAwOwo+ICsKPiArdmJsYW5rOgo+ICsJZHJtX3ZibGFua19jbGVhbnVwKGRybSk7Cj4g K2RldmljZToKPiArCWhvc3QxeF9kZXZpY2VfZXhpdChkZXZpY2UpOwo+ICtmYmRldjoKPiArCWRy bV9rbXNfaGVscGVyX3BvbGxfZmluaShkcm0pOwo+ICsJdGVncmFfZHJtX2ZiX2ZyZWUoZHJtKTsK PiArY29uZmlnOgo+ICsJZHJtX21vZGVfY29uZmlnX2NsZWFudXAoZHJtKTsKPiArCWtmcmVlKHRl Z3JhKTsKPiArCXJldHVybiBlcnI7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgdGVncmFfZHJtX3Vu bG9hZChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vdGVncmEvZHJtLmggYi9kcml2ZXJzL2dwdS9kcm0vdGVncmEvZHJtLmgKPiBpbmRleCBiOTk0 YzAxNzk3MWQuLmVmMmZhYWVmNTkzNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGVn cmEvZHJtLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdGVncmEvZHJtLmgKPiBAQCAtMjg4LDYg KzI4OCw3IEBAIGJvb2wgdGVncmFfZmJfaXNfYm90dG9tX3VwKHN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmZyYW1lYnVmZmVyKTsKPiAgaW50IHRlZ3JhX2ZiX2dldF90aWxpbmcoc3RydWN0IGRybV9m cmFtZWJ1ZmZlciAqZnJhbWVidWZmZXIsCj4gIAkJCXN0cnVjdCB0ZWdyYV9ib190aWxpbmcgKnRp bGluZyk7Cj4gIGludCB0ZWdyYV9kcm1fZmJfcHJlcGFyZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJt KTsKPiArdm9pZCB0ZWdyYV9kcm1fZmJfZnJlZShzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKTsKPiAg aW50IHRlZ3JhX2RybV9mYl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pOwo+ICB2b2lkIHRl Z3JhX2RybV9mYl9leGl0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pOwo+ICAjaWZkZWYgQ09ORklH X0RSTV9URUdSQV9GQkRFVgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGVncmEvZmIu YyBiL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS9mYi5jCj4gaW5kZXggMzUxM2QxMmQ1YWExLi4wNDc0 MjQxYWMyYTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2ZiLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vdGVncmEvZmIuYwo+IEBAIC0yODksNiArMjg5LDExIEBAIHN0YXRp YyBzdHJ1Y3QgdGVncmFfZmJkZXYgKnRlZ3JhX2ZiZGV2X2NyZWF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZHJtKQo+ICAJcmV0dXJuIGZiZGV2Owo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCB0ZWdyYV9m YmRldl9mcmVlKHN0cnVjdCB0ZWdyYV9mYmRldiAqZmJkZXYpCj4gK3sKPiArCWtmcmVlKGZiZGV2 KTsKPiArfQo+ICsKPiAgc3RhdGljIGludCB0ZWdyYV9mYmRldl9pbml0KHN0cnVjdCB0ZWdyYV9m YmRldiAqZmJkZXYsCj4gIAkJCSAgICB1bnNpZ25lZCBpbnQgcHJlZmVycmVkX2JwcCwKPiAgCQkJ ICAgIHVuc2lnbmVkIGludCBudW1fY3J0YywKPiBAQCAtMzIyLDcgKzMyNyw3IEBAIGZpbmk6Cj4g IAlyZXR1cm4gZXJyOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCB0ZWdyYV9mYmRldl9mcmVlKHN0 cnVjdCB0ZWdyYV9mYmRldiAqZmJkZXYpCj4gK3N0YXRpYyB2b2lkIHRlZ3JhX2ZiZGV2X2V4aXQo c3RydWN0IHRlZ3JhX2ZiZGV2ICpmYmRldikKPiAgewo+ICAJc3RydWN0IGZiX2luZm8gKmluZm8g PSBmYmRldi0+YmFzZS5mYmRldjsKPiAgCj4gQEAgLTM0NSw3ICszNTAsNyBAQCBzdGF0aWMgdm9p ZCB0ZWdyYV9mYmRldl9mcmVlKHN0cnVjdCB0ZWdyYV9mYmRldiAqZmJkZXYpCj4gIAl9Cj4gIAo+ ICAJZHJtX2ZiX2hlbHBlcl9maW5pKCZmYmRldi0+YmFzZSk7Cj4gLQlrZnJlZShmYmRldik7Cj4g Kwl0ZWdyYV9mYmRldl9mcmVlKGZiZGV2KTsKPiAgfQo+ICAKPiAgdm9pZCB0ZWdyYV9mYmRldl9y ZXN0b3JlX21vZGUoc3RydWN0IHRlZ3JhX2ZiZGV2ICpmYmRldikKPiBAQCAtMzkzLDYgKzM5OCwx NSBAQCBpbnQgdGVncmFfZHJtX2ZiX3ByZXBhcmUoc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiAg CXJldHVybiAwOwo+ICB9Cj4gIAo+ICt2b2lkIHRlZ3JhX2RybV9mYl9mcmVlKHN0cnVjdCBkcm1f ZGV2aWNlICpkcm0pCj4gK3sKPiArI2lmZGVmIENPTkZJR19EUk1fVEVHUkFfRkJERVYKPiArCXN0 cnVjdCB0ZWdyYV9kcm0gKnRlZ3JhID0gZHJtLT5kZXZfcHJpdmF0ZTsKPiArCj4gKwl0ZWdyYV9m YmRldl9mcmVlKHRlZ3JhLT5mYmRldik7Cj4gKyNlbmRpZgo+ICt9Cj4gKwo+ICBpbnQgdGVncmFf ZHJtX2ZiX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiAgewo+ICAjaWZkZWYgQ09ORklH X0RSTV9URUdSQV9GQkRFVgo+IEBAIC00MTMsNiArNDI3LDYgQEAgdm9pZCB0ZWdyYV9kcm1fZmJf ZXhpdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ICAjaWZkZWYgQ09ORklHX0RSTV9URUdSQV9G QkRFVgo+ICAJc3RydWN0IHRlZ3JhX2RybSAqdGVncmEgPSBkcm0tPmRldl9wcml2YXRlOwo+ICAK PiAtCXRlZ3JhX2ZiZGV2X2ZyZWUodGVncmEtPmZiZGV2KTsKPiArCXRlZ3JhX2ZiZGV2X2V4aXQo dGVncmEtPmZiZGV2KTsKPiAgI2VuZGlmCj4gIH0KPiAtLSAKPiAyLjEuMwo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==