From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 3/6] drm/plane: Add optional ->atomic_disable() callback Date: Tue, 25 Nov 2014 12:22:34 +0100 Message-ID: <20141125112234.GX25711@phenom.ffwll.local> References: <1416913789-23209-1-git-send-email-thierry.reding@gmail.com> <1416913789-23209-3-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E22E6E398 for ; Tue, 25 Nov 2014 03:22:09 -0800 (PST) Received: by mail-wi0-f176.google.com with SMTP id ex7so8787695wid.3 for ; Tue, 25 Nov 2014 03:22:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <1416913789-23209-3-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMjUsIDIwMTQgYXQgMTI6MDk6NDZQTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBJ biBvcmRlciB0byBwcmV2ZW50IGRyaXZlcnMgZnJvbSBoYXZpbmcgdG8gcGVyZm9ybSB0aGUgc2Ft ZSBjaGVja3Mgb3Zlcgo+IGFuZCBvdmVyIGFnYWluLCBhZGQgYW4gb3B0aW9uYWwgLT5hdG9taWNf ZGlzYWJsZSBjYWxsYmFjayB3aGljaCB0aGUgY29yZQo+IGNhbGxzIHVuZGVyIHRoZSByaWdodCBj aXJjdW1zdGFuY2VzLgo+IAo+IHYyOiBwYXNzIG9sZCBzdGF0ZSBhbmQgZGV0ZWN0IGVkZ2VzIHRv IGF2b2lkIGNhbGxpbmcgLT5hdG9taWNfZGlzYWJsZSBvbgo+IGFscmVhZHkgZGlzYWJsZWQgcGxh bmVzLCByZW1vdmUgcmVkdW5kYW50IGNvbW1lbnQgKERhbmllbCBWZXR0ZXIpCj4gCj4gU2lnbmVk LW9mZi1ieTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KClNvbWUgbWlub3Ig YmlrZXNoZWRzIGFib3V0IGNvbnNpc3RlbmN5IGFuZCBjbGFyaXR5IGJlbG93Lgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDE1ICsrKysrKysrKysrKystLQo+ ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lX2hlbHBlci5jICB8IDEwICsrKysrKysrKy0KPiAg aW5jbHVkZS9kcm0vZHJtX2NydGMuaCAgICAgICAgICAgICAgfCAyNiArKysrKysrKysrKysrKysr KysrKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1fcGxhbmVfaGVscGVyLmggICAgICB8ICAzICsr Kwo+ICA0IGZpbGVzIGNoYW5nZWQsIDUxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBpbmRleCA3ZjAyMDQwM2ZmZTAuLmEx YzdkMWI3M2Y4NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gQEAgLTEw MjAsMTIgKzEwMjAsMjMgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAgCQlmdW5jcyA9IHBs YW5lLT5oZWxwZXJfcHJpdmF0ZTsKPiAtCj4gLQkJaWYgKCFmdW5jcyB8fCAhZnVuY3MtPmF0b21p Y191cGRhdGUpCj4gKwkJaWYgKCFmdW5jcykKPiAgCQkJY29udGludWU7Cj4gIAo+ICAJCW9sZF9w bGFuZV9zdGF0ZSA9IG9sZF9zdGF0ZS0+cGxhbmVfc3RhdGVzW2ldOwo+ICAKPiArCQkvKgo+ICsJ CSAqIFNwZWNpYWwtY2FzZSBkaXNhYmxpbmcgdGhlIHBsYW5lIGlmIGRyaXZlcnMgc3VwcG9ydCBp dC4KPiArCQkgKi8KPiArCQlpZiAoZHJtX3BsYW5lX2Rpc2FibGVkKHBsYW5lLCBvbGRfcGxhbmVf c3RhdGUpICYmCj4gKwkJICAgIGZ1bmNzLT5hdG9taWNfZGlzYWJsZSkgewo+ICsJCQlmdW5jcy0+ YXRvbWljX2Rpc2FibGUocGxhbmUsIG9sZF9wbGFuZV9zdGF0ZSk7Cj4gKwkJCWNvbnRpbnVlOwo+ ICsJCX0KPiArCj4gKwkJaWYgKCFmdW5jcy0+YXRvbWljX3VwZGF0ZSkKPiArCQkJY29udGludWU7 CgpUaGlzIGxvb2tzIGRhbmdlcm91cyAtIHdlIHJlYWxseSBzaG91bGQgZWl0aGVyIGhhdmUgdGhl IGF0b21pY19kaXNhYmxlIG9yCmF0IGxlYXN0IGF0b21pY191cGRhdGUuIEFuZCBwbGFuZSB0cmFu c2l0aW9uYWwgaGVscGVycyBleGFjdGx5IHJlcXVpcmUKdGhhdC4gT24gdGhlIGJpa2VzaGVkIGZy b250IEkgYWxzbyBsaWtlIHRoZSBwbGFuZSBoZWxwZXIgc3RydWN0dXJlIG1vcmUKd2l0aCB0aGUg aWYgKCkgYXRvbWljX2Rpc2FsYmVsIGVsc2UgYXRvbWljX3VwZGF0ZSBpbnN0ZWFkIG9mIHRoZSBj b250aW51ZS4KCj4gKwo+ICAJCWZ1bmNzLT5hdG9taWNfdXBkYXRlKHBsYW5lLCBvbGRfcGxhbmVf c3RhdGUpOwo+ICAJfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFu ZV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmVfaGVscGVyLmMKPiBpbmRleCBh YTM5OWRiNWQzNmQuLjhjODFkM2E5ZTYyNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX3BsYW5lX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZV9oZWxw ZXIuYwo+IEBAIC00NDMsNyArNDQzLDE1IEBAIGludCBkcm1fcGxhbmVfaGVscGVyX2NvbW1pdChz dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCQkJY3J0Y19mdW5jc1tpXS0+YXRvbWljX2JlZ2lu KGNydGNbaV0pOwo+ICAJfQo+ICAKPiAtCXBsYW5lX2Z1bmNzLT5hdG9taWNfdXBkYXRlKHBsYW5l LCBwbGFuZV9zdGF0ZSk7Cj4gKwkvKgo+ICsJICogRHJpdmVycyBtYXkgb3B0aW9uYWxseSBpbXBs ZW1lbnQgdGhlIC0+YXRvbWljX2Rpc2FibGUgY2FsbGJhY2ssIHNvCj4gKwkgKiBzcGVjaWFsLWNh c2UgdGhhdCBoZXJlLgo+ICsJICovCj4gKwlpZiAoZHJtX3BsYW5lX2Rpc2FibGVkKHBsYW5lLCBw bGFuZV9zdGF0ZSkgJiYKPiArCSAgICBwbGFuZV9mdW5jcy0+YXRvbWljX2Rpc2FibGUpCj4gKwkJ cGxhbmVfZnVuY3MtPmF0b21pY19kaXNhYmxlKHBsYW5lLCBwbGFuZV9zdGF0ZSk7Cj4gKwllbHNl Cj4gKwkJcGxhbmVfZnVuY3MtPmF0b21pY191cGRhdGUocGxhbmUsIHBsYW5lX3N0YXRlKTsKPiAg Cj4gIAlmb3IgKGkgPSAwOyBpIDwgMjsgaSsrKSB7Cj4gIAkJaWYgKGNydGNfZnVuY3NbaV0gJiYg Y3J0Y19mdW5jc1tpXS0+YXRvbWljX2ZsdXNoKQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9k cm1fY3J0Yy5oIGIvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+IGluZGV4IDZkYTY3ZGZjYjZmYy4u ODBkMGYxYzJiMjY1IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgKPiArKysg Yi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gQEAgLTc5NSw2ICs3OTUsMzIgQEAgc3RydWN0IGRy bV9wbGFuZSB7Cj4gIAlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZTsKPiAgfTsKPiAgCj4g Ky8qCj4gKyAqIGRybV9wbGFuZV9kaXNhYmxlZCAtIGNoZWNrIHdoZXRoZXIgYSBwbGFuZSBpcyBi ZWluZyBkaXNhYmxlZAo+ICsgKiBAcGxhbmU6IHBsYW5lIG9iamVjdAo+ICsgKiBAb2xkX3N0YXRl OiBwcmV2aW91cyBhdG9taWMgc3RhdGUKPiArICoKPiArICogQ2hlY2tzIHRoZSBhdG9taWMgc3Rh dGUgb2YgYSBwbGFuZSB0byBkZXRlcm1pbmUgd2hldGhlciBpdCdzIGJlaW5nIGRpc2FibGVkCj4g KyAqIG9yIG5vdC4gVGhpcyBhbHNvIFdBUk5zIGlmIGl0IGRldGVjdHMgYW4gaW52YWxpZCBzdGF0 ZSAoYm90aCBDUlRDIGFuZCBGQgo+ICsgKiBuZWVkIHRvIGVpdGhlciBib3RoIGJlIE5VTEwgb3Ig Ym90aCBiZSBub24tTlVMTCkuCj4gKyAqCj4gKyAqIFJFVFVSTlM6Cj4gKyAqIFRydWUgaWYgdGhl IHBsYW5lIGlzIGJlaW5nIGRpc2FibGVkLCBmYWxzZSBvdGhlcndpc2UuCj4gKyAqLwo+ICtzdGF0 aWMgaW5saW5lIGJvb2wgZHJtX3BsYW5lX2Rpc2FibGVkKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l LAo+ICsJCQkJICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3N0YXRlKQo+ICt7Cj4g KwkvKgo+ICsJICogV2hlbiBkaXNhYmxpbmcgYSBwbGFuZSwgQ1JUQyBhbmQgRkIgc2hvdWxkIGFs d2F5cyBiZSBOVUxMIHRvZ2V0aGVyLgo+ICsJICogQW55dGhpbmcgZWxzZSBzaG91bGQgYmUgY29u c2lkZXJlZCBhIGJ1ZyBpbiB0aGUgYXRvbWljIGNvcmUsIHNvIHdlCj4gKwkgKiBnZW50bHkgd2Fy biBhYm91dCBpdC4KPiArCSAqLwo+ICsJV0FSTl9PTigocGxhbmUtPnN0YXRlLT5jcnRjID09IE5V TEwgJiYgcGxhbmUtPnN0YXRlLT5mYiAhPSBOVUxMKSB8fAo+ICsJCShwbGFuZS0+c3RhdGUtPmNy dGMgIT0gTlVMTCAmJiBwbGFuZS0+c3RhdGUtPmZiID09IE5VTEwpKTsKPiArCj4gKwlyZXR1cm4g KCFvbGRfc3RhdGUgfHwgb2xkX3N0YXRlLT5jcnRjKSAmJiAhcGxhbmUtPnN0YXRlLT5jcnRjOwoK VGhlICFvbGRfc3RhdGUgY2hlY2sgaGVyZSBjb25mdXNlZCBtZSBhIGJpdCwgdW50aWwgSSd2ZSBy ZWFsaXplZCB0aGF0IHlvdQp1c2UgdGhpcyBmb3IgdHJhbnNpdGlvbmFsIGhlbHBlcnMgdG9vLiBX aGF0IGFib3V0IGFkZGluZwoKCS8qIENvcGUgd2l0aCBOVUxMIG9sZF9zdGF0ZSBmb3IgdHJhbnNp dGlvbmFsIGhlbHBlcnMuICovCgpyaWdodCBhYm92ZT8KCj4gK30KCkhtLCBnaXZlbiB0aGF0IHRo aXMgaXMgdXNlZCBieSBoZWxwZXJzIG1heWJlIHBsYWNlIGl0IGludG8KZHJtX2F0b21pY19oZWxw ZXIuaD8gSSdtIGFsc28gbm90IHRvbyBoYXBweSBhYm91dCB0aGUgbmFtZSwgZGlzYWJsZWQKZG9l c24ndCBjbGVhcmx5IG9ubHkgbWVhbiB0aGUgZW5hYmxlLT5kaXNhYmxlIHRyYW5zaXRpb24uIFdo YXQgYWJvdXQKZHJtX2F0b21pY19wbGFuZV9kaXNhYmxpbmcgaW5zdGVhZCwgdG8gbWFrZSBpdCBj bGVhciB3ZSBvbmx5IGNhcmUgYWJvdXQKdGhlIHRyYW5zaXRpb24/IEFmdGVyIGFsbCB5b3VyIGtl cm5lbGRvYyBhbHNvIHVzZXMgY29udGludW91cyAoImJlaW5nCmRpc2FibGVkIikuCgo+ICsKPiAg LyoqCj4gICAqIHN0cnVjdCBkcm1fYnJpZGdlX2Z1bmNzIC0gZHJtX2JyaWRnZSBjb250cm9sIGZ1 bmN0aW9ucwo+ICAgKiBAbW9kZV9maXh1cDogVHJ5IHRvIGZpeHVwIChvciByZWplY3QgZW50aXJl bHkpIHByb3Bvc2VkIG1vZGUgZm9yIHRoaXMgYnJpZGdlCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv ZHJtL2RybV9wbGFuZV9oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9wbGFuZV9oZWxwZXIuaAo+ IGluZGV4IDBmMjIzMDMxMWFhOC4uNjgwYmU2MWVmMjBhIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUv ZHJtL2RybV9wbGFuZV9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9wbGFuZV9oZWxw ZXIuaAo+IEBAIC01Miw2ICs1Miw3IEBAIGludCBkcm1fY3J0Y19pbml0KHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgICogQGNsZWFudXBfZmI6IGNsZWFu dXAgYSBmcmFtZWJ1ZmZlciB3aGVuIGl0J3Mgbm8gbG9uZ2VyIHVzZWQgYnkgdGhlIHBsYW5lCj4g ICAqIEBhdG9taWNfY2hlY2s6IGNoZWNrIHRoYXQgYSBnaXZlbiBhdG9taWMgc3RhdGUgaXMgdmFs aWQgYW5kIGNhbiBiZSBhcHBsaWVkCj4gICAqIEBhdG9taWNfdXBkYXRlOiBhcHBseSBhbiBhdG9t aWMgc3RhdGUgdG8gdGhlIHBsYW5lCj4gKyAqIEBhdG9taWNfZGlzYWJsZTogZGlzYWJsZSB0aGUg cGxhbmUKPiAgICoKPiAgICogVGhlIGhlbHBlciBvcGVyYXRpb25zIGFyZSBjYWxsZWQgYnkgdGhl IG1pZC1sYXllciBDUlRDIGhlbHBlci4KPiAgICovCj4gQEAgLTY1LDYgKzY2LDggQEAgc3RydWN0 IGRybV9wbGFuZV9oZWxwZXJfZnVuY3Mgewo+ICAJCQkgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0 ZSAqc3RhdGUpOwo+ICAJdm9pZCAoKmF0b21pY191cGRhdGUpKHN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lLAo+ICAJCQkgICAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpvbGRfc3RhdGUpOwo+ICsJ dm9pZCAoKmF0b21pY19kaXNhYmxlKShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiArCQkJICAg ICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9zdGF0ZSk7Cj4gIH07Cj4gIAo+ICBzdGF0 aWMgaW5saW5lIHZvaWQgZHJtX3BsYW5lX2hlbHBlcl9hZGQoc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4gLS0gCj4gMi4xLjMKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==