From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH libdrm] drm: Avoid out of bound write in drmOpenByName() Date: Mon, 1 Dec 2014 16:32:39 +0100 Message-ID: <20141201153239.GT32117@phenom.ffwll.local> References: <1417442823-10301-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id B3F386E547 for ; Mon, 1 Dec 2014 07:32:10 -0800 (PST) Received: by mail-wi0-f170.google.com with SMTP id bs8so27160535wib.5 for ; Mon, 01 Dec 2014 07:32:09 -0800 (PST) Content-Disposition: inline In-Reply-To: <1417442823-10301-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Damien Lespiau Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBEZWMgMDEsIDIwMTQgYXQgMDI6MDc6MDNQTSArMDAwMCwgRGFtaWVuIExlc3BpYXUg d3JvdGU6Cj4gSW4gdGhlIGZhbGxiYWNrIGNvZGUgdGhhdCBsb29rcyBmb3IgZGV2aWNlcyBpbiAv cHJvYywgdGhlIHJlYWQoKSBtYXkKPiByZXR1cm4gd2l0aCAtMSBpbiBjYXNlIG9mIGVycm9yIChp bnRlcnJ1cHRpb24gZnJvbSBhIHNpZ25hbCBmb3IKPiBpbnN0YW5jZSkuIFdlJ2xsIHRoZW4gaGFw cGlseSB3cml0ZSAnXDAnIHRvIGJ1ZlstMl0uCj4gCj4gQXMgd2UgZGlkbid0IHJlYWxseSBjYXJl IGFib3V0IHRoZSBzaWduYWwgaW50ZXJydXB0aW9uIGJlZm9yZSwgSSBrZXB0IGl0Cj4gdGhlIHNh bWUgd2F5LCBqdXN0IG1ha2luZyBzdXJlIHRoYXQgcmV0Y29kZSBpcyA+IDAgdG8gYXZvaWQgdGhh dCBjYXNlLgo+IAo+IFRoaXMgd2FzIGZvdW5kIGJ5IHN0YXRpYyBhbmFseXNpcy4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVuLmxlc3BpYXVAaW50ZWwuY29tPgoKcHJv Y2ZzIHN1cHBvcnQgaXMgZGVhZCwgYWJzb2x1dGVseSBubyBwb2ludCBpbW8gdG8gZml4IGl0LiBG cm9tIHRoZQprZXJuZWw6Cgpjb21taXQgY2I2NDU4Zjk3YjUzZDdmNzMwNDMyMDZjMTgwMTRiM2Nh NjNhYzM0NQpBdXRob3I6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CkRh dGU6ICAgVGh1IEF1ZyA4IDE1OjQxOjM0IDIwMTMgKzAyMDAKCiAgICBkcm06IHJlbW92ZSBwcm9j ZnMgY29kZSwgdGFrZSAyCiAgICAKICAgIFNvIGFsbW9zdCB0d28geWVhcnMgYWdvIEkndmUgdHJp ZWQgdG8gbnVrZSB0aGUgcHJvY2ZzIGNvZGUgYWxyZWFkeQogICAgb25jZSBiZWZvcmU6CiAgICAK ICAgIGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTEt T2N0b2Jlci8wMTU3MDcuaHRtbAogICAgCiAgICBUaGUgY29uY2x1c2lvbiB3YXMgdGhhdCB1c2Vy c3BhY2UgZHJpdmVycyAoc3BlY2lmaWNhbGx5IGxpYmRybSBkZXZpY2UKICAgIG5vZGUgZGV0ZWN0 aW9uKSBzdG9wcGVkIHJlbHlpbmcgb24gcHJvY2ZzIGluIDIwMDEuIEJ1dCBhZnRlciBzb21lCiAg ICBkaWdnaW5nIGl0IHR1cm5lZCBvdXQgdGhhdCB0aGUgZHJtc3RhdCB0b29sIGluIGxpYmRybSBp cyBzdGlsbCB1c2luZwogICAgdGhvc2UgZmlsZXMgKGJ1dCBvbmx5IHdoZW4gY2VydGFpbiBvcHRp b25zIGFyZSBzZXQpLiBTbyB3ZSd2ZSBkZWNpZGVkCiAgICB0byBrZWVwIHByb2Zjcy4KICAgIAog ICAgQnV0IEkgd2hlbiBJJ3ZlIHN0YXJ0ZWQgdG8gZGlnIGFyb3VuZCBhZ2FpbiB3aGF0IGV4YWN0 bHkgdGhpcyB0b29sCiAgICBkb2VzIEkndmUgbm90aWNlZCB0aGF0IGl0IHRyaWVzIHRvIHJlYWQg dGhlICJtZW0iLCAidm0iLCBhbmQgInZtYSIKICAgIGZpbGVzIGZyb20gcHJvY2ZzLiBOb3cgYXMg ZmFyIG15IGdpdCBoaXN0b3J5IGRpZ2dpbmcgc2hvd3MgIm1lbSIgbmV2ZXIKICAgIGRpZCBhbnl0 aGluZyB1c2VmdWwgKGF0IGxlYXN0IGluIHRoZSB2ZXJzaW9uIHRoYXQgZmlyc3Qgc2hvd2VkIHVw IGluCiAgICB1cHN0cmVhbSBoaXN0b3J5IGluIDIwMDQpIGFuZCB0aGUgZmlsZSB3YXMgcmVtb3Zl IGluCiAgICAKICAgIGNvbW1pdCA5NTViMTJkZWY0MmU4MzI4N2MxYmRiMTQxMWQ5OTQ1MTc1M2Mx MzkxCiAgICBBdXRob3I6IEJlbiBHYW1hcmkgPGJnYW1hcmlAZ21haWwuY29tPgogICAgRGF0ZTog ICBUdWUgRmViIDE3IDIwOjA4OjQ5IDIwMDkgLTA1MDAKICAgIAogICAgICAgIGRybTogQ29udmVy dCBwcm9jIGZpbGVzIHRvIHNlcV9maWxlIGFuZCBpbnRyb2R1Y2UgZGVidWdmcwogICAgCiAgICBX aGljaCBtZWFucyB0aGF0IGZvciBvdmVyIDQgeWVhcnMgZHJtc3RhdCBoYXMgYmVlbiBicm9rZW4s IGFuZCBubyBvbmUKICAgIGNhcmVkLiBJbiBteSBvcGluaW9uIHRoYXQncyBwcm9vZiBlbm91Z2gg dGhhdCBubyBvbmUgaXMgYWN0dWFsbHkgdXNpbmcKICAgIGRybXN0YXQsIGFuZCBzbyB0aGF0IHdl IGNhbiBzYXZlbHkgbnVrZSB0aGUgcHJvY2ZzIHN1cHBvcnQgZnJvbSBkcm0uCiAgICAKICAgIFdo aWxlIGF0IGl0IGZpeCB1cCB0aGUgZXJyb3IgY2FzZSBjbGVhbnVwIGZvciBkZWJ1Z2ZzIGluIGRy bV9nZXRfbWlub3IuCiAgICAKICAgIHYyOiBGaXggZGF0ZXMsIGxpYmRybSBzdG9wcGVkIHJlbHlp bmcgb24gcHJvY2ZzIGZvciBkcm0gbm9kZSBkZXRlY3Rpb24KICAgIGluIDIwMDEuCiAgICAKICAg IHYzOiBmaXh1cCBjb21waWxhdGlvbiB3YXJuaW5nIGZvciAhQ09ORklHX0RFQlVHX0ZTLCByZXBv cnRlZCBieQogICAgRmVuZ2d1YW5nIFd1LgogICAgCiAgICBDYzoga2J1aWxkIHRlc3Qgcm9ib3Qg PGZlbmdndWFuZy53dUBpbnRlbC5jb20+CiAgICBDYzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAbGlu dXguaWU+CiAgICBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgogICAgU2lnbmVkLW9mZi1ieTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNv bT4KCgpJbnN0ZWFkIEkgdGhpbmsgd2Ugc2hvdWxkIGp1c3QgcmlwIHRoaXMgZmFsbGJhY2sgY29k ZSBvdXQuIFZvbHVudGVlcmVkPwpZb3UgY2FuIHJldXNlIHRoZSBkaWdnaW5nIEkndmUgZG9uZSBm b3IgdGhlIGtlcm5lbCBzaWRlLgoKQ2hlZXJzLCBEYW5pZWwKPiAtLS0KPiAgeGY4NmRybS5jIHwg MiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEveGY4NmRybS5jIGIveGY4NmRybS5jCj4gaW5kZXggZDkwMGI0Yi4uMTA2 YjhhYiAxMDA2NDQKPiAtLS0gYS94Zjg2ZHJtLmMKPiArKysgYi94Zjg2ZHJtLmMKPiBAQCAtNTc5 LDcgKzU3OSw3IEBAIHN0YXRpYyBpbnQgZHJtT3BlbkJ5TmFtZShjb25zdCBjaGFyICpuYW1lKQo+ ICAJaWYgKChmZCA9IG9wZW4ocHJvY19uYW1lLCAwLCAwKSkgPj0gMCkgewo+ICAJICAgIHJldGNv ZGUgPSByZWFkKGZkLCBidWYsIHNpemVvZihidWYpLTEpOwo+ICAJICAgIGNsb3NlKGZkKTsKPiAt CSAgICBpZiAocmV0Y29kZSkgewo+ICsJICAgIGlmIChyZXRjb2RlID4gMCkgewo+ICAJCWJ1Zlty ZXRjb2RlLTFdID0gJ1wwJzsKPiAgCQlmb3IgKGRyaXZlciA9IHB0ID0gYnVmOyAqcHQgJiYgKnB0 ICE9ICcgJzsgKytwdCkKPiAgCQkgICAgOwo+IC0tIAo+IDEuOC4zLjEKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0 ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3 IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK