From: Dan Carpenter <dan.carpenter@oracle.com>
To: mark.yao@rock-chips.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm: rockchip: Add basic drm driver
Date: Tue, 16 Dec 2014 14:51:29 +0300 [thread overview]
Message-ID: <20141216115128.GA9761@mwanda> (raw)
Hello Mark Yao,
The patch 2048e3286f34: "drm: rockchip: Add basic drm driver" from
Aug 22, 2014, leads to the following static checker warning:
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1383 vop_bind()
warn: unsigned 'vop->irq' is never less than zero.
drivers/gpu/drm/rockchip/rockchip_drm_vop.c
1381
1382 vop->irq = platform_get_irq(pdev, 0);
1383 if (vop->irq < 0) {
^^^^^^^^^^^^
Doesn't work.
1384 dev_err(dev, "cannot find irq for vop\n");
1385 return vop->irq;
1386 }
1387
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1188 vop_create_crtc()
warn: missing error code here? 'of_get_child_by_name()' failed.
1184 port = of_get_child_by_name(dev->of_node, "port");
1185 if (!port) {
1186 DRM_ERROR("no port node found in %s\n",
1187 dev->of_node->full_name);
Probably, "ret = -ENODEV;"
1188 goto err_cleanup_crtc;
1189 }
1190
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2014-12-16 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:51 Dan Carpenter [this message]
2014-12-17 0:56 ` drm: rockchip: Add basic drm driver Mark yao
2014-12-17 12:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216115128.GA9761@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mark.yao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox