From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/info: Remove unused code
Date: Tue, 16 Dec 2014 18:44:45 +0100 [thread overview]
Message-ID: <20141216174445.GX2711@phenom.ffwll.local> (raw)
In-Reply-To: <1418727733-16341-1-git-send-email-thierry.reding@gmail.com>
On Tue, Dec 16, 2014 at 12:02:13PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Commit 28a62277e06f ("drm: Convert proc files to seq_file and introduce
> debugfs") converted /proc files to debugfs and in the process dropped
> the entry for the vblank statistics. Since that file has been gone for
> almost five years, there is no use to keep the code that provides the
> file's content around.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_info.c | 24 ------------------------
> drivers/gpu/drm/drm_internal.h | 1 -
> 2 files changed, 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_info.c b/drivers/gpu/drm/drm_info.c
> index 51efebd434f3..f1b32f91d941 100644
> --- a/drivers/gpu/drm/drm_info.c
> +++ b/drivers/gpu/drm/drm_info.c
> @@ -153,30 +153,6 @@ int drm_bufs_info(struct seq_file *m, void *data)
> }
>
> /**
> - * Called when "/proc/dri/.../vblank" is read.
> - */
> -int drm_vblank_info(struct seq_file *m, void *data)
> -{
> - struct drm_info_node *node = (struct drm_info_node *) m->private;
> - struct drm_device *dev = node->minor->dev;
> - int crtc;
> -
> - mutex_lock(&dev->struct_mutex);
> - for (crtc = 0; crtc < dev->num_crtcs; crtc++) {
> - seq_printf(m, "CRTC %d enable: %d\n",
> - crtc, atomic_read(&dev->vblank[crtc].refcount));
> - seq_printf(m, "CRTC %d counter: %d\n",
> - crtc, drm_vblank_count(dev, crtc));
> - seq_printf(m, "CRTC %d last wait: %d\n",
> - crtc, dev->vblank[crtc].last_wait);
> - seq_printf(m, "CRTC %d in modeset: %d\n",
> - crtc, dev->vblank[crtc].inmodeset);
> - }
> - mutex_unlock(&dev->struct_mutex);
> - return 0;
> -}
> -
> -/**
> * Called when "/proc/dri/.../clients" is read.
> *
> */
> diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
> index 7cc0a3516871..12a61d706827 100644
> --- a/drivers/gpu/drm/drm_internal.h
> +++ b/drivers/gpu/drm/drm_internal.h
> @@ -55,7 +55,6 @@ void drm_prime_remove_buf_handle_locked(struct drm_prime_file_private *prime_fpr
> int drm_name_info(struct seq_file *m, void *data);
> int drm_vm_info(struct seq_file *m, void *data);
> int drm_bufs_info(struct seq_file *m, void *data);
> -int drm_vblank_info(struct seq_file *m, void *data);
> int drm_clients_info(struct seq_file *m, void* data);
> int drm_gem_name_info(struct seq_file *m, void *data);
>
> --
> 2.1.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-12-16 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:02 [PATCH] drm/info: Remove unused code Thierry Reding
2014-12-16 17:44 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216174445.GX2711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox