From: Thierry Reding <treding@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: drm/dsi: Add message to packet translator
Date: Wed, 17 Dec 2014 11:58:06 +0100 [thread overview]
Message-ID: <20141217105805.GD5646@ulmo.nvidia.com> (raw)
In-Reply-To: <20141216235305.GC31467@mwanda>
[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]
On Wed, Dec 17, 2014 at 02:53:05AM +0300, Dan Carpenter wrote:
> Hello Thierry Reding,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch a52879e8d7cb: "drm/dsi: Add message to packet translator"
> from Oct 16, 2014, leads to the following Smatch complaint:
>
> drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet()
> warn: variable dereferenced before check 'msg' (see line 326)
>
> drivers/gpu/drm/drm_mipi_dsi.c
> 325 {
> 326 const u8 *tx = msg->tx_buf;
> ^^^^^^^^^^^
> Dereference.
>
> 327
> 328 if (!packet || !msg)
> ^^^^
> Check.
>
> 329 return -EINVAL;
> 330
>
> regards,
> dan carpenter
I've had a patch in my tree for almost two weeks now, I wonder why this
is still there...
Ah, forgot to push it of course. Done now.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-12-17 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:53 drm/dsi: Add message to packet translator Dan Carpenter
2014-12-17 10:58 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217105805.GD5646@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox