From: Thierry Reding <treding@nvidia.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
dan.carpenter@oracle.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/dsi: Do the 'msg' check prior to dereferencing it.
Date: Wed, 17 Dec 2014 11:59:21 +0100 [thread overview]
Message-ID: <20141217105920.GE5646@ulmo.nvidia.com> (raw)
In-Reply-To: <1418774674-14390-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 778 bytes --]
On Tue, Dec 16, 2014 at 10:04:34PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Commit a52879e8d7cb ("drm/dsi: Add message to packet translator") caused the
> following Smatch complaint:
>
> drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet()
> warn: variable dereferenced before check 'msg' (see line 326)
>
> Do the 'msg' check prior to dereferencing it.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
I've had an equivalent patch in the drm/panel tree for almost two weeks
but had forgotten to push. Pushed now.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-12-17 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 0:04 [PATCH] drm/dsi: Do the 'msg' check prior to dereferencing it Fabio Estevam
2014-12-17 10:59 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217105920.GE5646@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox