From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Adam Jackson <ajax@redhat.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/3] drm: Basic mode sanity checks
Date: Fri, 19 Dec 2014 18:54:53 +0200 [thread overview]
Message-ID: <20141219165453.GS10649@intel.com> (raw)
In-Reply-To: <1419003962.25275.1.camel@dmt>
On Fri, Dec 19, 2014 at 10:46:02AM -0500, Adam Jackson wrote:
> On Wed, 2014-12-17 at 18:30 +0100, Daniel Vetter wrote:
>
> > All pulled into my drm misc branch.
>
> Ugh, wish I'd caught this earlier. I'm not entirely thrilled with
> requiring non-zero clock, it's not a concept that makes sense on virtual
> hardware.
I'm thinking none of the timing information makes much sense in such
cases. Well, except hdisplay/vdisplay but that's only because our API
sucks a bit and doesn't have the concept of crtc input vs. output size.
hdisplay/vdisplay are used to mean one or the other, depending on the
driver/hardware/output.
That said, I could be convinced to drop the clock check if you think it
can cause problems in the common code.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-12-19 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 11:56 [PATCH 0/3] drm: Basic mode sanity checks ville.syrjala
2014-12-17 11:56 ` [PATCH 1/3] drm: Reorganize probed mode validation ville.syrjala
2014-12-17 11:56 ` [PATCH 2/3] drm: Perform basic sanity checks on probed modes ville.syrjala
2014-12-17 11:56 ` [PATCH 3/3] drm: Do basic sanity checks for user modes ville.syrjala
2014-12-17 17:09 ` [PATCH 0/3] drm: Basic mode sanity checks Alex Deucher
2014-12-17 17:30 ` Daniel Vetter
2014-12-19 15:46 ` Adam Jackson
2014-12-19 16:54 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219165453.GS10649@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox