From: Philipp Zabel <pza@pengutronix.de>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] imx-drm: core: handling of DI clock flags to ipu_crtc_mode_set()
Date: Mon, 22 Dec 2014 16:28:21 +0100 [thread overview]
Message-ID: <20141222152821.GA32333@pengutronix.de> (raw)
In-Reply-To: <E1Y2itf-0008SD-Km@rmk-PC.arm.linux.org.uk>
Hi Russell,
On Sun, Dec 21, 2014 at 03:58:19PM +0000, Russell King wrote:
> We do not need to track the state of the IPU DI's clock flags by having
> each display bridge calling back into imx-drm-core, and then back out
> into ipuv3-crtc.c.
>
> ipuv3-crtc can instead just scan the list of encoders to retrieve their
> type, and build up a picture of which types of encoders are attached.
> We can then use this information to configure the IPU DI clocking mode
> without any uncertainty - if we have multiple bridges connected to the
> same DI, if one of them requires a synchronous DI clock, that's what we
> must use.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> This is a clean-up which I've had sitting around for some time, but
> which I think would be useful to get into mainline at some point
> (maybe 3.20?)
Looks good to me, I'll add it to the queue.
thanks
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-12-22 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 15:58 [PATCH] imx-drm: core: handling of DI clock flags to ipu_crtc_mode_set() Russell King
2014-12-22 15:28 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222152821.GA32333@pengutronix.de \
--to=pza@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox